Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: commit to db after computing flag and component comparisons #222

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

joseph-sentry
Copy link
Contributor

This is an attempt to fix an issue where flag comparisons are not being saved to the database.

@codecov-staging
Copy link

codecov-staging bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #222   +/-   ##
=======================================
  Coverage   98.24%   98.24%           
=======================================
  Files         366      366           
  Lines       29474    29476    +2     
=======================================
+ Hits        28956    28958    +2     
  Misses        518      518           
Flag Coverage Δ
integration 98.24% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 98.24% <100.00%> (+<0.01%) ⬆️
unit 98.24% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.48% <100.00%> (+<0.01%) ⬆️
OutsideTasks 97.95% <ø> (ø)
Files Coverage Δ
tasks/compute_comparison.py 100.00% <100.00%> (ø)

@codecov-qa
Copy link

codecov-qa bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0d4ec53) 98.24% compared to head (176c000) 98.24%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #222   +/-   ##
=======================================
  Coverage   98.24%   98.24%           
=======================================
  Files         366      366           
  Lines       29474    29476    +2     
=======================================
+ Hits        28956    28958    +2     
  Misses        518      518           
Flag Coverage Δ
integration 98.24% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 98.24% <100.00%> (+<0.01%) ⬆️
unit 98.24% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.48% <100.00%> (+<0.01%) ⬆️
OutsideTasks 97.95% <ø> (ø)
Files Coverage Δ
tasks/compute_comparison.py 100.00% <100.00%> (ø)

Copy link

codecov-public-qa bot commented Dec 21, 2023

Codecov Report

Merging #222 (176c000) into main (0d4ec53) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #222   +/-   ##
=======================================
  Coverage   98.24%   98.24%           
=======================================
  Files         366      366           
  Lines       29474    29476    +2     
=======================================
+ Hits        28956    28958    +2     
  Misses        518      518           
Flag Coverage Δ
integration 98.24% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 98.24% <100.00%> (+<0.01%) ⬆️
unit 98.24% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.48% <100.00%> (+<0.01%) ⬆️
OutsideTasks 97.95% <ø> (ø)
Files Coverage Δ
tasks/compute_comparison.py 100.00% <100.00%> (ø)

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0d4ec53) 98.21% compared to head (176c000) 98.21%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #222   +/-   ##
=======================================
  Coverage   98.21%   98.21%           
=======================================
  Files         397      397           
  Lines       30174    30176    +2     
=======================================
+ Hits        29635    29637    +2     
  Misses        539      539           
Flag Coverage Δ
integration 98.24% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 98.24% <100.00%> (+<0.01%) ⬆️
unit 98.24% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.38% <100.00%> (+<0.01%) ⬆️
OutsideTasks 97.95% <ø> (ø)
Files Coverage Δ
tasks/compute_comparison.py 100.00% <100.00%> (ø)

This change has been scanned for critical changes. Learn more

Copy link
Contributor

@adrian-codecov adrian-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Odd this isn't working as normal but lets do it!

@joseph-sentry joseph-sentry merged commit a67e8b1 into main Dec 21, 2023
29 of 30 checks passed
@joseph-sentry joseph-sentry deleted the joseph/commit-flag-comparison branch December 21, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants