-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: commit to db after computing flag and component comparisons #222
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #222 +/- ##
=======================================
Coverage 98.24% 98.24%
=======================================
Files 366 366
Lines 29474 29476 +2
=======================================
+ Hits 28956 28958 +2
Misses 518 518
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #222 +/- ##
=======================================
Coverage 98.24% 98.24%
=======================================
Files 366 366
Lines 29474 29476 +2
=======================================
+ Hits 28956 28958 +2
Misses 518 518
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov Report
@@ Coverage Diff @@
## main #222 +/- ##
=======================================
Coverage 98.24% 98.24%
=======================================
Files 366 366
Lines 29474 29476 +2
=======================================
+ Hits 28956 28958 +2
Misses 518 518
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #222 +/- ##
=======================================
Coverage 98.21% 98.21%
=======================================
Files 397 397
Lines 30174 30176 +2
=======================================
+ Hits 29635 29637 +2
Misses 539 539
Flags with carried forward coverage won't be shown. Click here to find out more.
This change has been scanned for critical changes. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Odd this isn't working as normal but lets do it!
This is an attempt to fix an issue where flag comparisons are not being saved to the database.