Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add more info to path fix logs #221

Merged
merged 2 commits into from
Dec 29, 2023

Conversation

joseph-sentry
Copy link
Contributor

No description provided.

@codecov-staging
Copy link

codecov-staging bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #221   +/-   ##
=======================================
  Coverage   98.24%   98.24%           
=======================================
  Files         366      366           
  Lines       29475    29475           
=======================================
  Hits        28957    28957           
  Misses        518      518           
Flag Coverage Δ
integration 98.24% <ø> (ø)
latest-uploader-overall 98.24% <ø> (ø)
unit 98.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.48% <ø> (ø)
OutsideTasks 97.95% <ø> (ø)
Files Coverage Δ
services/report/raw_upload_processor.py 94.65% <ø> (ø)

@codecov-qa
Copy link

codecov-qa bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8615836) 98.24% compared to head (84c0f20) 98.24%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #221   +/-   ##
=======================================
  Coverage   98.24%   98.24%           
=======================================
  Files         366      366           
  Lines       29475    29475           
=======================================
  Hits        28957    28957           
  Misses        518      518           
Flag Coverage Δ
integration 98.24% <ø> (ø)
latest-uploader-overall 98.24% <ø> (ø)
unit 98.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.48% <ø> (ø)
OutsideTasks 97.95% <ø> (ø)
Files Coverage Δ
services/report/raw_upload_processor.py 94.65% <ø> (ø)

Copy link

codecov-public-qa bot commented Dec 20, 2023

Codecov Report

Merging #221 (84c0f20) into main (8615836) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #221   +/-   ##
=======================================
  Coverage   98.24%   98.24%           
=======================================
  Files         366      366           
  Lines       29475    29475           
=======================================
  Hits        28957    28957           
  Misses        518      518           
Flag Coverage Δ
integration 98.24% <ø> (ø)
latest-uploader-overall 98.24% <ø> (ø)
unit 98.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.48% <ø> (ø)
OutsideTasks 97.95% <ø> (ø)
Files Coverage Δ
services/report/raw_upload_processor.py 94.65% <ø> (ø)

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8615836) 98.21% compared to head (84c0f20) 98.21%.

Changes have been made to critical files, which contain lines commonly executed in production. Learn more

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #221   +/-   ##
=======================================
  Coverage   98.21%   98.21%           
=======================================
  Files         397      397           
  Lines       30175    30176    +1     
=======================================
+ Hits        29636    29637    +1     
  Misses        539      539           
Flag Coverage Δ
integration 98.24% <ø> (ø)
latest-uploader-overall 98.24% <ø> (ø)
onlysomelabels 98.18% <ø> (-0.04%) ⬇️
unit 98.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.38% <ø> (+<0.01%) ⬆️
OutsideTasks 97.95% <ø> (ø)
Files Coverage Δ
services/report/raw_upload_processor.py 94.65% <ø> (ø)

... and 1 file with indirect coverage changes

This change has been scanned for critical changes. Learn more

extra={
"fixes": actual_path_fixes.items(),
"toc": path_fixer.toc,
"disable_default_pathfixes": path_fixer.should_disable_default_pathfixes,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just making sure it's pathfixes and not path_fixes

@joseph-sentry joseph-sentry merged commit e8057e7 into main Dec 29, 2023
29 checks passed
@joseph-sentry joseph-sentry deleted the joseph/update-path-fix-logs branch December 29, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants