fix: mark commits coming from forks in branch #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the branch name of a commit that is part of a PR from a fork. This prevents branch collision issues where the coverage from a branch in the target repo is overwritten by an upload coming from a fork. The CLI has logic to add the branch, the API as well, but those are ignored when uploading the commit info from provider. Might as well build the logic here instead of trsuting CLI and API.
giovanni-guidini
requested review from
matt-codecov,
scott-codecov,
adrian-codecov and
joseph-sentry
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #217 +/- ##
=======================================
Coverage 98.23% 98.24%
=======================================
Files 362 362
Lines 29141 29168 +27
=======================================
+ Hits 28628 28655 +27
Misses 513 513
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov Report
@@ Coverage Diff @@
## main #217 +/- ##
=======================================
Coverage 98.23% 98.24%
=======================================
Files 362 362
Lines 29141 29168 +27
=======================================
+ Hits 28628 28655 +27
Misses 513 513
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov Report
Changes have been made to critical files, which contain lines commonly executed in production. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #217 +/- ##
=======================================
Coverage 98.21% 98.21%
=======================================
Files 393 393
Lines 29841 29868 +27
=======================================
+ Hits 29307 29334 +27
Misses 534 534
Flags with carried forward coverage won't be shown. Click here to find out more.
|
joseph-sentry
approved these changes
Dec 15, 2023
scott-codecov
added a commit
that referenced
this pull request
Dec 15, 2023
* main: fix: mark commits coming from forks in branch (#217)
scott-codecov
added a commit
that referenced
this pull request
Dec 15, 2023
* main: fix: mark commits coming from forks in branch (#217)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the branch name of a commit that is part of a PR from a fork.
This prevents branch collision issues where the coverage from a branch
in the target repo is overwritten by an upload coming from a fork.
The CLI has logic to add the branch, the API as well, but those are
ignored when uploading the commit info from provider.
Might as well build the logic here instead of trsuting CLI and API.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.