feat: Add bundle analysis processor task #215
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #215 +/- ##
========================================
Coverage 98.24% 98.24%
========================================
Files 362 366 +4
Lines 29168 29474 +306
========================================
+ Hits 28655 28956 +301
- Misses 513 518 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov Report
@@ Coverage Diff @@
## main #215 +/- ##
========================================
Coverage 98.24% 98.24%
========================================
Files 362 366 +4
Lines 29168 29474 +306
========================================
+ Hits 28655 28956 +301
- Misses 513 518 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov Report
Changes have been made to critical files, which contain lines commonly executed in production. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #215 +/- ##
========================================
Coverage 98.21% 98.21%
========================================
Files 393 397 +4
Lines 29868 30175 +307
========================================
+ Hits 29334 29636 +302
- Misses 534 539 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes
|
scott-codecov
requested review from
adrian-codecov,
giovanni-guidini,
joseph-sentry and
matt-codecov
scott-codecov
force-pushed
the
scott/bundle-analysis-processor
branch
from
579395d
to
2721693
Compare
| bundle_report = BundleAnalysisReport() | ||
|
|
||
| # download raw upload data to local tempfile | ||
| _, local_path = tempfile.mkstemp() |
There was a problem hiding this comment.
Who's responsible for cleaning up this local_path?
I see that the BuindleAnalysisReport does clean up its own report file (the sqlite one). But I don't think that's the same as local_path...
In any case it was not clear, so maybe add a comment saying who does the cleanup?
There was a problem hiding this comment.
Oh good point. I can delete it in this function right after calling ingest. I'll do it in a finally block so we cleanup even on an unexpected exception. And come to think of it - I'm not actually calling the bundle_report.cleanup() method either. I'll do that right before the task ends.
I think these will get cleaned up by the OS (since they're in /tmp) but probably a good practice to do it ourselves as well.
| self.countdown = countdown | ||
|
|
||
|
|
||
| class LockManager: |
There was a problem hiding this comment.
Damn that's cool... nice
Codecov ReportAttention: @@ Coverage Diff @@
## main #215 +/- ##
========================================
Coverage 98.24% 98.24%
========================================
Files 362 366 +4
Lines 29168 29474 +306
========================================
+ Hits 28655 28956 +301
- Misses 513 518 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
scott-codecov
force-pushed
the
scott/bundle-analysis-processor
branch
2 times, most recently
from
6630b13
to
a3f443b
Compare
scott-codecov
force-pushed
the
scott/bundle-analysis-processor
branch
from
a3f443b
to
705c17f
Compare
Similar to the existing upload processor task but for processing bundle analysis uploads.