chore: rename comparison base commit fields to project/patch base #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #213 +/- ##
=======================================
Coverage 98.33% 98.33%
=======================================
Files 358 358
Lines 28869 28869
=======================================
Hits 28389 28389
Misses 480 480
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov Report
@@ Coverage Diff @@
## main #213 +/- ##
=======================================
Coverage 98.33% 98.33%
=======================================
Files 358 358
Lines 28869 28869
=======================================
Hits 28389 28389
Misses 480 480
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov Report
Changes have been made to critical files, which contain lines commonly executed in production. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #213 +/- ##
=======================================
Coverage 98.30% 98.30%
=======================================
Files 389 389
Lines 29565 29565
=======================================
Hits 29064 29064
Misses 501 501
Flags with carried forward coverage won't be shown. Click here to find out more.
|
giovanni-guidini
approved these changes
Dec 13, 2023
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #203
no logical changes, pure rename
hoping tests exercised every usage of these variables. i grepped for some usage patterns but my brain would melt if i tried to go through every occurrence of the word "base" to make sure none refer to this
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.