Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow triggering of AI PR review based on PR labels #206

Merged
merged 3 commits into from
Dec 6, 2023

Conversation

scott-codecov
Copy link
Contributor

@scott-codecov scott-codecov commented Dec 5, 2023

We'd like to allow triggering of an AI PR review based on adding a label to a PR. The API will trigger a sync pull task when receiving that webhook: codecov/codecov-api#294

More details in codecov/engineering-team#896

Depends on the shared changes from codecov/shared#96

TODO: update shared version once codecov/shared#96 is merged

Copy link

codecov-public-qa bot commented Dec 5, 2023

Codecov Report

Merging #206 (e545e97) into main (455f7e4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #206   +/-   ##
=======================================
  Coverage   98.35%   98.35%           
=======================================
  Files         356      356           
  Lines       28485    28525   +40     
=======================================
+ Hits        28015    28057   +42     
+ Misses        470      468    -2     
Flag Coverage Δ
integration 98.35% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 98.35% <100.00%> (+<0.01%) ⬆️
unit 98.35% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.76% <100.00%> (+0.02%) ⬆️
OutsideTasks 98.14% <ø> (ø)
Files Coverage Δ
tasks/sync_pull.py 98.70% <100.00%> (+1.42%) ⬆️
tasks/tests/unit/test_sync_pull.py 100.00% <100.00%> (ø)

@codecov-qa
Copy link

codecov-qa bot commented Dec 5, 2023

Codecov Report

Merging #206 (e545e97) into main (455f7e4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #206   +/-   ##
=======================================
  Coverage   98.35%   98.35%           
=======================================
  Files         356      356           
  Lines       28485    28525   +40     
=======================================
+ Hits        28015    28057   +42     
+ Misses        470      468    -2     
Flag Coverage Δ
integration 98.35% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 98.35% <100.00%> (+<0.01%) ⬆️
unit 98.35% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.76% <100.00%> (+0.02%) ⬆️
OutsideTasks 98.14% <ø> (ø)
Files Coverage Δ
tasks/sync_pull.py 98.70% <100.00%> (+1.42%) ⬆️
tasks/tests/unit/test_sync_pull.py 100.00% <100.00%> (ø)

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Merging #206 (e545e97) into main (455f7e4) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Changes have been made to critical files, which contain lines commonly executed in production. Learn more

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #206      +/-   ##
==========================================
+ Coverage   98.31%   98.32%   +0.01%     
==========================================
  Files         387      387              
  Lines       29180    29219      +39     
==========================================
+ Hits        28689    28731      +42     
+ Misses        491      488       -3     
Flag Coverage Δ
integration 98.35% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 98.35% <100.00%> (+<0.01%) ⬆️
unit 98.35% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.65% <100.00%> (+0.02%) ⬆️
OutsideTasks 98.14% <ø> (ø)
Files Coverage Δ
tasks/sync_pull.py 98.70% <100.00%> (+1.41%) ⬆️
tasks/tests/unit/test_sync_pull.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

Related Entrypoints
run/app.tasks.pulls.Sync

@scott-codecov scott-codecov merged commit cf5611f into main Dec 6, 2023
25 of 26 checks passed
@scott-codecov scott-codecov deleted the scott/ai-pr-review-labels branch December 6, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants