chore(deps): Update codecov-shared dependency #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FraBle
changed the title
trent-codecov
requested review from
matt-codecov,
scott-codecov and
giovanni-guidini
requirements.txt
Outdated
| @@ -16,8 +16,6 @@ anyio==3.6.1 | |||
| # via | |||
| # httpcore | |||
| # openai | |||
| async-timeout==4.0.2 | |||
There was a problem hiding this comment.
Why did it remove these things?... maybe it's a python 3.12 thing? That is fairly new.
When I run locally it doesn't remove anything. Could you put them back?...
There was a problem hiding this comment.
Sure, I just pushed a commit reversing the removal.
giovanni-guidini
approved these changes
Nov 30, 2023
scott-codecov
added a commit
that referenced
this pull request
Dec 6, 2023
* main: Only trigger AI PR review if pull is open Add log line when triggering AI PR review task fix: use original PR base to compute patch coverage (#199) Prepare release 23.12.4 Update workflows chore(deps): Update codecov-shared dependency (#194) Prep the terrain for reports with label compression. (#188) allow staging deploy when pushing to staging (#192)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose/Motivation
Update
shared, which includes a fix for the install schema validation that previously errored when specifyingadmins, which is required for self-hosting codecov.Links to relevant tickets
N/A
What does this PR do?
Upgrades
sharedto the latest Git hash, which includes the fix PR.Notes to Reviewer
Anything to note to the team? Any tips on how to review, or where to start?
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.