Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(notify): add additional logging on deletion failures #185

Merged
merged 5 commits into from
Nov 20, 2023

Conversation

drazisil-codecov
Copy link
Contributor

No description provided.

Copy link
Contributor

@giovanni-guidini giovanni-guidini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change. Tests appear to be broken...
Can pull be None? (because you are using pull.repoid)

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Merging #185 (dda29ff) into main (8df9cfe) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #185   +/-   ##
=======================================
  Coverage   98.34%   98.34%           
=======================================
  Files         376      376           
  Lines       28088    28088           
=======================================
+ Hits        27622    27624    +2     
+ Misses        466      464    -2     
Flag Coverage Δ
integration 98.37% <ø> (ø)
latest-uploader-overall 98.37% <ø> (ø)
unit 98.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.75% <ø> (+0.01%) ⬆️
OutsideTasks 98.15% <ø> (ø)
Files Coverage Δ
...ervices/notification/notifiers/comment/__init__.py 99.45% <ø> (ø)

... and 1 file with indirect coverage changes

This change has been scanned for critical changes. Learn more

@codecov-staging
Copy link

codecov-staging bot commented Nov 20, 2023

Codecov Report

Merging #185 (dda29ff) into main (8df9cfe) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #185   +/-   ##
=======================================
  Coverage   98.37%   98.37%           
=======================================
  Files         347      347           
  Lines       27443    27443           
=======================================
  Hits        26998    26998           
  Misses        445      445           
Flag Coverage Δ
integration 98.37% <ø> (ø)
latest-uploader-overall 98.37% <ø> (ø)
unit 98.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.86% <ø> (ø)
OutsideTasks 98.15% <ø> (ø)
Files Coverage Δ
...ervices/notification/notifiers/comment/__init__.py 99.45% <ø> (ø)

@codecov-qa
Copy link

codecov-qa bot commented Nov 20, 2023

Codecov Report

Merging #185 (dda29ff) into main (8df9cfe) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #185   +/-   ##
=======================================
  Coverage   98.37%   98.37%           
=======================================
  Files         347      347           
  Lines       27443    27443           
=======================================
  Hits        26998    26998           
  Misses        445      445           
Flag Coverage Δ
integration 98.37% <ø> (ø)
latest-uploader-overall 98.37% <ø> (ø)
unit 98.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.86% <ø> (ø)
OutsideTasks 98.15% <ø> (ø)
Files Coverage Δ
...ervices/notification/notifiers/comment/__init__.py 99.45% <ø> (ø)

@drazisil-codecov drazisil-codecov merged commit 7c5fbdf into main Nov 20, 2023
25 of 26 checks passed
@drazisil-codecov drazisil-codecov deleted the drazisil-codecov-patch-1 branch November 20, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants