Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Use get_github_integration_token and cache from shared #181

Merged
merged 3 commits into from
Nov 20, 2023

Conversation

scott-codecov
Copy link
Contributor

Cleanup after moving some worker code into shared (codecov/shared#78)

@codecov-staging
Copy link

codecov-staging bot commented Nov 13, 2023

Codecov Report

Merging #181 (40ad914) into main (f1041b2) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #181      +/-   ##
==========================================
- Coverage   98.38%   98.37%   -0.01%     
==========================================
  Files         350      347       -3     
  Lines       27721    27443     -278     
==========================================
- Hits        27274    26998     -276     
+ Misses        447      445       -2     
Flag Coverage Δ
integration 98.37% <100.00%> (-0.01%) ⬇️
latest-uploader-overall 98.37% <100.00%> (-0.01%) ⬇️
unit 98.37% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.86% <100.00%> (-0.02%) ⬇️
OutsideTasks 98.15% <100.00%> (-0.02%) ⬇️
Files Coverage Δ
celery_config.py 66.66% <100.00%> (+0.51%) ⬆️
helpers/cache.py 100.00% <100.00%> (+1.86%) ⬆️
services/github.py 100.00% <100.00%> (ø)
services/notification/notifiers/status/base.py 98.66% <100.00%> (+<0.01%) ⬆️
...s/notification/notifiers/tests/unit/test_status.py 100.00% <ø> (ø)
services/tests/integration/test_bots.py 100.00% <100.00%> (ø)

@codecov-qa
Copy link

codecov-qa bot commented Nov 13, 2023

Codecov Report

Merging #181 (40ad914) into main (f1041b2) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #181      +/-   ##
==========================================
- Coverage   98.38%   98.37%   -0.01%     
==========================================
  Files         350      347       -3     
  Lines       27721    27443     -278     
==========================================
- Hits        27274    26998     -276     
+ Misses        447      445       -2     
Flag Coverage Δ
integration 98.37% <100.00%> (-0.01%) ⬇️
latest-uploader-overall 98.37% <100.00%> (-0.01%) ⬇️
unit 98.37% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.86% <100.00%> (-0.02%) ⬇️
OutsideTasks 98.15% <100.00%> (-0.02%) ⬇️
Files Coverage Δ
celery_config.py 66.66% <100.00%> (+0.51%) ⬆️
helpers/cache.py 100.00% <100.00%> (+1.86%) ⬆️
services/github.py 100.00% <100.00%> (ø)
services/notification/notifiers/status/base.py 98.66% <100.00%> (+<0.01%) ⬆️
...s/notification/notifiers/tests/unit/test_status.py 100.00% <ø> (ø)
services/tests/integration/test_bots.py 100.00% <100.00%> (ø)

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #181 (40ad914) into main (f1041b2) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Changes have been made to critical files, which contain lines commonly executed in production. Learn more

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #181      +/-   ##
==========================================
- Coverage   98.34%   98.34%   -0.01%     
==========================================
  Files         376      376              
  Lines       28217    28088     -129     
==========================================
- Hits        27751    27622     -129     
  Misses        466      466              
Flag Coverage Δ
integration 98.37% <100.00%> (-0.01%) ⬇️
latest-uploader-overall 98.37% <100.00%> (-0.01%) ⬇️
unit 98.37% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.74% <100.00%> (-0.04%) ⬇️
OutsideTasks 98.15% <100.00%> (-0.02%) ⬇️
Files Coverage Δ
celery_config.py 66.66% <100.00%> (+0.51%) ⬆️
helpers/cache.py Critical 100.00% <100.00%> (+1.81%) ⬆️
services/github.py 100.00% <100.00%> (ø)
services/notification/notifiers/status/base.py 98.66% <100.00%> (+<0.01%) ⬆️
...s/notification/notifiers/tests/unit/test_status.py 100.00% <ø> (ø)
services/tests/integration/test_bots.py 100.00% <100.00%> (ø)
Related Entrypoints
run/app.tasks.upload.UploadProcessor
run/app.tasks.pulls.Sync
run/app.tasks.notify.Notify
run/app.tasks.status.SetError
run/app.tasks.compute_comparison.ComputeComparison
run/app.tasks.upload.Upload
run/app.tasks.upload.PreProcessUpload
run/app.tasks.commit_update.CommitUpdate
run/app.tasks.label_analysis.process_request
run/app.tasks.sync_repos.SyncRepos
run/app.tasks.sync_plans.SyncPlans

@scott-codecov scott-codecov merged commit 8df9cfe into main Nov 20, 2023
26 checks passed
@scott-codecov scott-codecov deleted the scott/update-shared branch November 20, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants