tests: update smtp unit tests #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #179 +/- ##
=======================================
Coverage 98.38% 98.38%
=======================================
Files 350 350
Lines 27721 27721
=======================================
Hits 27274 27274
Misses 447 447
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #179 +/- ##
=======================================
Coverage 98.38% 98.38%
=======================================
Files 350 350
Lines 27721 27721
=======================================
Hits 27274 27274
Misses 447 447
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #179 +/- ##
=======================================
Coverage 98.34% 98.34%
=======================================
Files 376 376
Lines 28217 28217
=======================================
Hits 27751 27751
Misses 466 466
Flags with carried forward coverage won't be shown. Click here to find out more.
This change has been scanned for critical changes. Learn more |
joseph-sentry
force-pushed
the
joseph/update-smtp-tests
branch
from
77f14da
to
7e97b63
Compare
joseph-sentry
requested review from
dana-yaish,
giovanni-guidini,
scott-codecov and
matt-codecov
giovanni-guidini
approved these changes
Nov 13, 2023
This commit adds the reset_connection fixture to some tests that were broken in the ATS CI step. The reason they were broken is because the order of the tests being ran was hiding this issue of reusing the existing SMTP connection across tests. Signed-off-by: joseph-sentry <[email protected]>
joseph-sentry
force-pushed
the
joseph/update-smtp-tests
branch
from
7e97b63
to
820941f
Compare
updated the commit message to try and make it more clear |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some smtp unit tests are broken in ATS sometimes, this PR attempts to fix them