[ezpz] metrics: add bigger bucket sizes for a couple prometheus histograms #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-codecov
requested review from
dana-yaish,
giovanni-guidini,
scott-codecov and
joseph-sentry
Codecov Report
@@ Coverage Diff @@
## main #178 +/- ##
=======================================
Coverage 98.38% 98.38%
=======================================
Files 350 350
Lines 27700 27700
=======================================
Hits 27253 27253
Misses 447 447
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #178 +/- ##
=======================================
Coverage 98.38% 98.38%
=======================================
Files 350 350
Lines 27700 27700
=======================================
Hits 27253 27253
Misses 447 447
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov Report
Changes have been made to critical files, which contain lines commonly executed in production. Learn more @@ Coverage Diff @@
## main #178 +/- ##
=======================================
Coverage 98.34% 98.34%
=======================================
Files 376 376
Lines 28196 28196
=======================================
Hits 27730 27730
Misses 466 466
Flags with carried forward coverage won't be shown. Click here to find out more.
This change has been scanned for critical changes. Learn more |
joseph-sentry
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the median
time_in_queuevalue is very frequently higher than 10. since there's no bucket higher than that, promql just returns 10 when querying the median so the metric is not usefulthe p95
notification_latencyis often more than 900 seconds. the metric is still useful despite that, but may as well add bigger bucketssee the problem + watch for the solution in some of the graphs here https://l.codecov.dev/rVDScT (internal only)
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.