Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cobertura): Handle cobertura partials to hits #176

Merged
merged 2 commits into from
Nov 9, 2023

Conversation

joseph-sentry
Copy link
Contributor

@joseph-sentry joseph-sentry commented Nov 6, 2023

This commit adds behaviour to handle the partials_to_hits codecov.yml option for the cobertura parser.

When this option is enabled, the cobertura parser will convert partials (not misses) to hits, by setting the coverage to 1, the missing branches to None, and the line type to None.

Related: codecov/shared#76

This commit adds behaviour to handle the partials_to_hits
codecov.yml option for the cobertura parser.

When this option is enabled, the cobertura parser will convert
partials (not misses) to hits, by setting the coverage to 1, the
missing branches to None, and the line type to None.

Signed-off-by: joseph-sentry <[email protected]>
@joseph-sentry joseph-sentry force-pushed the joseph/cobertura-partials-to-hits branch from 4c58b01 to cdff964 Compare November 6, 2023 23:17
@codecov-staging
Copy link

codecov-staging bot commented Nov 6, 2023

Codecov Report

Merging #176 (10aa8da) into main (d410085) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #176   +/-   ##
=======================================
  Coverage   98.38%   98.38%           
=======================================
  Files         350      350           
  Lines       27700    27721   +21     
=======================================
+ Hits        27253    27274   +21     
  Misses        447      447           
Flag Coverage Δ
integration 98.38% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 98.38% <100.00%> (+<0.01%) ⬆️
unit 98.38% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.88% <100.00%> (+<0.01%) ⬆️
OutsideTasks 98.17% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
services/report/languages/cobertura.py 96.26% <100.00%> (+0.14%) ⬆️
...ices/report/languages/tests/unit/test_cobertura.py 100.00% <100.00%> (ø)

@codecov-qa
Copy link

codecov-qa bot commented Nov 6, 2023

Codecov Report

Merging #176 (10aa8da) into main (d410085) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #176   +/-   ##
=======================================
  Coverage   98.38%   98.38%           
=======================================
  Files         350      350           
  Lines       27700    27721   +21     
=======================================
+ Hits        27253    27274   +21     
  Misses        447      447           
Flag Coverage Δ
integration 98.38% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 98.38% <100.00%> (+<0.01%) ⬆️
unit 98.38% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.88% <100.00%> (+<0.01%) ⬆️
OutsideTasks 98.17% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
services/report/languages/cobertura.py 96.26% <100.00%> (+0.14%) ⬆️
...ices/report/languages/tests/unit/test_cobertura.py 100.00% <100.00%> (ø)

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #176 (10aa8da) into main (d410085) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Changes have been made to critical files, which contain lines commonly executed in production. Learn more

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #176   +/-   ##
=======================================
  Coverage   98.34%   98.34%           
=======================================
  Files         376      376           
  Lines       28196    28217   +21     
=======================================
+ Hits        27730    27751   +21     
  Misses        466      466           
Flag Coverage Δ
integration 98.38% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 98.38% <100.00%> (+<0.01%) ⬆️
unit 98.38% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.77% <100.00%> (+<0.01%) ⬆️
OutsideTasks 98.17% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
services/report/languages/cobertura.py Critical 96.26% <100.00%> (+0.14%) ⬆️
...ices/report/languages/tests/unit/test_cobertura.py 100.00% <100.00%> (ø)

This change has been scanned for critical changes. Learn more

@joseph-sentry joseph-sentry merged commit a873c92 into main Nov 9, 2023
25 of 26 checks passed
@joseph-sentry joseph-sentry deleted the joseph/cobertura-partials-to-hits branch November 9, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants