Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle report size for readonlyreports #173

Merged
merged 3 commits into from
Nov 6, 2023

Conversation

scott-codecov
Copy link
Contributor

@codecov-staging
Copy link

codecov-staging bot commented Nov 6, 2023

Codecov Report

Merging #173 (a83a296) into main (55177d9) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #173      +/-   ##
==========================================
- Coverage   98.38%   98.38%   -0.01%     
==========================================
  Files         350      350              
  Lines       27688    27685       -3     
==========================================
- Hits        27241    27238       -3     
  Misses        447      447              
Flag Coverage Δ
integration 98.38% <100.00%> (-0.01%) ⬇️
latest-uploader-overall 98.38% <100.00%> (-0.01%) ⬇️
unit 98.38% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.88% <100.00%> (-0.01%) ⬇️
OutsideTasks 98.17% <100.00%> (-0.01%) ⬇️
Files Coverage Δ
.../notification/notifiers/mixins/message/sections.py 96.15% <100.00%> (-0.04%) ⬇️

@codecov-qa
Copy link

codecov-qa bot commented Nov 6, 2023

Codecov Report

Merging #173 (a83a296) into main (55177d9) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #173      +/-   ##
==========================================
- Coverage   98.38%   98.38%   -0.01%     
==========================================
  Files         350      350              
  Lines       27688    27685       -3     
==========================================
- Hits        27241    27238       -3     
  Misses        447      447              
Flag Coverage Δ
integration 98.38% <100.00%> (-0.01%) ⬇️
latest-uploader-overall 98.38% <100.00%> (-0.01%) ⬇️
unit 98.38% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.88% <100.00%> (-0.01%) ⬇️
OutsideTasks 98.17% <100.00%> (-0.01%) ⬇️
Files Coverage Δ
.../notification/notifiers/mixins/message/sections.py 96.15% <100.00%> (-0.04%) ⬇️

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #173 (0ffc695) into main (5927c03) will decrease coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

❗ Current head 0ffc695 differs from pull request most recent head a83a296. Consider uploading reports for the commit a83a296 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #173      +/-   ##
==========================================
- Coverage   98.34%   98.34%   -0.01%     
==========================================
  Files         376      374       -2     
  Lines       28184    28141      -43     
==========================================
- Hits        27718    27675      -43     
  Misses        466      466              
Flag Coverage Δ
integration 98.38% <100.00%> (-0.01%) ⬇️
latest-uploader-overall 98.38% <100.00%> (-0.01%) ⬇️
onlysomelabels 97.64% <100.00%> (-0.01%) ⬇️
unit 98.38% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.77% <100.00%> (-0.01%) ⬇️
OutsideTasks 98.16% <100.00%> (-0.01%) ⬇️
Files Coverage Δ
.../notification/notifiers/mixins/message/sections.py 94.86% <100.00%> (-0.05%) ⬇️

... and 3 files with indirect coverage changes

Related Entrypoints
run/app.tasks.notify.Notify

@scott-codecov scott-codecov merged commit 931ebab into main Nov 6, 2023
19 checks passed
@scott-codecov scott-codecov deleted the scott/fix-report-size branch November 6, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants