Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle new sections names #171

Merged
merged 4 commits into from
Nov 9, 2023
Merged

handle new sections names #171

merged 4 commits into from
Nov 9, 2023

Conversation

dana-yaish
Copy link
Contributor

handle new names for the new sections. newheader, newfooter and newfiles are now condensed_header, condensed_footer and condensed_files

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

…les are now condensed_header, condensed_footer and condensed_files
@codecov-staging
Copy link

codecov-staging bot commented Nov 3, 2023

Codecov Report

Merging #171 (2aa6fc4) into main (efa624b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #171   +/-   ##
=======================================
  Coverage   98.38%   98.38%           
=======================================
  Files         350      350           
  Lines       27685    27700   +15     
=======================================
+ Hits        27238    27253   +15     
  Misses        447      447           
Flag Coverage Δ
integration 98.38% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 98.38% <100.00%> (+<0.01%) ⬆️
unit 98.38% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.88% <100.00%> (+<0.01%) ⬆️
OutsideTasks 98.17% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
.../notification/notifiers/mixins/message/__init__.py 100.00% <100.00%> (ø)
.../notification/notifiers/mixins/message/sections.py 96.15% <100.00%> (ø)
.../notification/notifiers/tests/unit/test_comment.py 100.00% <100.00%> (ø)

@codecov-qa
Copy link

codecov-qa bot commented Nov 3, 2023

Codecov Report

Merging #171 (2aa6fc4) into main (efa624b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #171   +/-   ##
=======================================
  Coverage   98.38%   98.38%           
=======================================
  Files         350      350           
  Lines       27685    27700   +15     
=======================================
+ Hits        27238    27253   +15     
  Misses        447      447           
Flag Coverage Δ
integration 98.38% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 98.38% <100.00%> (+<0.01%) ⬆️
unit 98.38% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.88% <100.00%> (+<0.01%) ⬆️
OutsideTasks 98.17% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
.../notification/notifiers/mixins/message/__init__.py 100.00% <100.00%> (ø)
.../notification/notifiers/mixins/message/sections.py 96.15% <100.00%> (ø)
.../notification/notifiers/tests/unit/test_comment.py 100.00% <100.00%> (ø)

Copy link

codecov-public-qa bot commented Nov 3, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@efa624b). Click here to learn what that means.
The diff coverage is 100.00%.

❗ Current head ec28166 differs from pull request most recent head 2aa6fc4. Consider uploading reports for the commit 2aa6fc4 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #171   +/-   ##
=======================================
  Coverage        ?   98.38%           
=======================================
  Files           ?      348           
  Lines           ?    27663           
  Branches        ?        0           
=======================================
  Hits            ?    27216           
  Misses          ?      447           
  Partials        ?        0           
Flag Coverage Δ
integration 98.38% <100.00%> (?)
latest-uploader-overall 98.38% <100.00%> (?)
unit 98.38% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.87% <100.00%> (?)
OutsideTasks 98.16% <100.00%> (?)
Files Coverage Δ
.../notification/notifiers/mixins/message/__init__.py 100.00% <100.00%> (ø)
.../notification/notifiers/mixins/message/sections.py 96.19% <100.00%> (ø)
.../notification/notifiers/tests/unit/test_comment.py 100.00% <100.00%> (ø)

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #171 (2aa6fc4) into main (efa624b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #171   +/-   ##
=======================================
  Coverage   98.34%   98.34%           
=======================================
  Files         376      376           
  Lines       28181    28196   +15     
=======================================
+ Hits        27715    27730   +15     
  Misses        466      466           
Flag Coverage Δ
integration 98.38% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 98.38% <100.00%> (+<0.01%) ⬆️
unit 98.38% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.77% <100.00%> (+<0.01%) ⬆️
OutsideTasks 98.17% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
.../notification/notifiers/mixins/message/__init__.py 100.00% <100.00%> (ø)
.../notification/notifiers/mixins/message/sections.py 94.86% <100.00%> (ø)
.../notification/notifiers/tests/unit/test_comment.py 100.00% <100.00%> (ø)
Related Entrypoints
run/app.tasks.notify.Notify

@dana-yaish dana-yaish merged commit d78f831 into main Nov 9, 2023
25 of 26 checks passed
@dana-yaish dana-yaish deleted the dana/handle-new-yaml-config branch November 9, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants