add timeseries models and django scaffold #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-codecov
force-pushed
the
matt/add-telemetry-django-models
branch
from
8a12a1f
to
9907464
Compare
Codecov Report
Changes have been made to critical files, which contain lines commonly executed in production. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #168 +/- ##
==========================================
- Coverage 98.29% 98.23% -0.06%
==========================================
Files 389 386 -3
Lines 29620 28721 -899
==========================================
- Hits 29114 28214 -900
- Misses 506 507 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 46 files with indirect coverage changes
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #168 +/- ##
==========================================
- Coverage 98.32% 98.23% -0.09%
==========================================
Files 358 362 +4
Lines 28923 29139 +216
==========================================
+ Hits 28438 28626 +188
- Misses 485 513 +28
Flags with carried forward coverage won't be shown. Click here to find out more.
|
matt-codecov
requested review from
giovanni-guidini,
joseph-sentry,
adrian-codecov,
trent-codecov and
scott-codecov
joseph-sentry
approved these changes
Nov 22, 2023
giovanni-guidini
approved these changes
Nov 24, 2023
Codecov Report
@@ Coverage Diff @@
## main #168 +/- ##
==========================================
- Coverage 98.35% 98.26% -0.09%
==========================================
Files 353 357 +4
Lines 27844 28076 +232
==========================================
+ Hits 27386 27590 +204
- Misses 458 486 +28
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This was referenced Nov 30, 2023
Codecov Report
@@ Coverage Diff @@
## main #168 +/- ##
==========================================
- Coverage 98.32% 98.23% -0.09%
==========================================
Files 358 362 +4
Lines 28923 29139 +216
==========================================
+ Hits 28438 28626 +188
- Misses 485 513 +28
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
codecov/engineering-team#547
codecov/shared#72
this PR creates a django scaffold in worker which:
shared(which were copied fromcodecov-api)pg_telemetryandts_telemetryapps to gain access to those modelsdjango.setup()during worker startupit also introduces a helper
MetricContextwhich wrapspg_telemetryandts_telemetryso we can log to both until we pick one. and a littleTimeseriesTimertimer utility as well. it usesTimeseriesTimerandMetricContextto log runtimes and success/failure/retry metrics inCodecovBaseTask. this gives us, for instance, per-repo success rates forupload_task, or per-owner runtimes forsync_repos_taskLegal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.