fix: remove some buggy validation of BaseFlow values #167
Conversation
matt-codecov
requested review from
giovanni-guidini,
scott-codecov,
rfox-codecov and
joseph-sentry
Codecov Report
Changes have been made to critical files, which contain lines commonly executed in production. Learn more @@ Coverage Diff @@
## main #167 +/- ##
=======================================
Coverage 98.34% 98.34%
=======================================
Files 374 374
Lines 28135 28144 +9
=======================================
+ Hits 27669 27678 +9
Misses 466 466
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
|
matt-codecov
force-pushed
the
matt/simplify-baseflow-values
branch
from
5bee15c
to
f3a351c
Compare
Codecov Report
@@ Coverage Diff @@
## main #167 +/- ##
=======================================
Coverage 98.38% 98.38%
=======================================
Files 348 348
Lines 27639 27648 +9
=======================================
+ Hits 27192 27201 +9
Misses 447 447
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #167 +/- ##
=======================================
Coverage 98.38% 98.38%
=======================================
Files 348 348
Lines 27639 27648 +9
=======================================
+ Hits 27192 27201 +9
Misses 447 447
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov Report
@@ Coverage Diff @@
## main #167 +/- ##
=======================================
Coverage 98.38% 98.38%
=======================================
Files 348 348
Lines 27639 27648 +9
=======================================
+ Hits 27192 27201 +9
Misses 447 447
Flags with carried forward coverage won't be shown. Click here to find out more.
|
tl;dr
fix
notification_latencyand otherUploadFlowmetrics by ceasing to inject the flow name into the value of each checkpoint in the flowexplanation
when serializing
MyEnumcheckpoints between tasks, i tried to inject the enum name into each enum value soMyEnum.Awould have a value of"MyEnum.A"instead of just"A". the idea being, when trying to continueMyEnumin the next task, we could completely validate that the checkpoints data we're deserializing really came fromMyEnummy hacky method for accomplishing this didn't work and adding further complexity to this validation is not worth it, so this PR rips it out. there is still some protection against mismatching flows: checkpoints data is put into
kwargswith a key that includes the flow nameLegal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.