-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add team plan to billing and upload limits #166
Conversation
Codecov Report
@@ Coverage Diff @@
## main #166 +/- ##
=======================================
Coverage 98.38% 98.38%
=======================================
Files 348 348
Lines 27607 27639 +32
=======================================
+ Hits 27160 27192 +32
Misses 447 447
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov Report
@@ Coverage Diff @@
## main #166 +/- ##
=======================================
Coverage 98.38% 98.38%
=======================================
Files 348 348
Lines 27607 27639 +32
=======================================
+ Hits 27160 27192 +32
Misses 447 447
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov Report
@@ Coverage Diff @@
## main #166 +/- ##
=======================================
Coverage 98.34% 98.34%
=======================================
Files 374 374
Lines 28103 28135 +32
=======================================
+ Hits 27637 27669 +32
Misses 466 466
Flags with carried forward coverage won't be shown. Click here to find out more.
|
) | ||
|
||
report = ReportFactory.create(commit=commit) | ||
for i in range(2499): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How long does this test take? I wonder if there's an easier way to mock this 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eh it added a quarter of a second on a pytest run with and without it in my docker container 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall lgtm! Optional suggestion otherwise gtg
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #166 +/- ##
=======================================
Coverage 98.38% 98.38%
=======================================
Files 348 348
Lines 27607 27639 +32
=======================================
+ Hits 27160 27192 +32
Misses 447 447
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.