Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add team plan to billing and upload limits #166

Merged
merged 4 commits into from
Nov 1, 2023
Merged

Conversation

JerrySentry
Copy link
Contributor

  • Add Team plan concept to upload limits, this plan has a 2500 limit.
  • Add Team plan to be recognized as a billing plan

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-staging
Copy link

codecov-staging bot commented Nov 1, 2023

Codecov Report

Merging #166 (6d93709) into main (8b81626) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #166   +/-   ##
=======================================
  Coverage   98.38%   98.38%           
=======================================
  Files         348      348           
  Lines       27607    27639   +32     
=======================================
+ Hits        27160    27192   +32     
  Misses        447      447           
Flag Coverage Δ
integration 98.38% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 98.38% <100.00%> (+<0.01%) ⬆️
unit 98.38% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.87% <100.00%> (+<0.01%) ⬆️
OutsideTasks 98.16% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
services/billing.py 100.00% <100.00%> (ø)
services/decoration.py 100.00% <100.00%> (ø)
services/tests/test_decoration.py 96.53% <100.00%> (+0.30%) ⬆️

Copy link

codecov-public-qa bot commented Nov 1, 2023

Codecov Report

Merging #166 (6d93709) into main (8b81626) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #166   +/-   ##
=======================================
  Coverage   98.38%   98.38%           
=======================================
  Files         348      348           
  Lines       27607    27639   +32     
=======================================
+ Hits        27160    27192   +32     
  Misses        447      447           
Flag Coverage Δ
integration 98.38% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 98.38% <100.00%> (+<0.01%) ⬆️
unit 98.38% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.87% <100.00%> (+<0.01%) ⬆️
OutsideTasks 98.16% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
services/billing.py 100.00% <100.00%> (ø)
services/decoration.py 100.00% <100.00%> (ø)
services/tests/test_decoration.py 96.53% <100.00%> (+0.30%) ⬆️

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #166 (6d93709) into main (8b81626) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #166   +/-   ##
=======================================
  Coverage   98.34%   98.34%           
=======================================
  Files         374      374           
  Lines       28103    28135   +32     
=======================================
+ Hits        27637    27669   +32     
  Misses        466      466           
Flag Coverage Δ
integration 98.38% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 98.38% <100.00%> (+<0.01%) ⬆️
unit 98.38% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.77% <100.00%> (+<0.01%) ⬆️
OutsideTasks 98.16% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
services/billing.py 100.00% <100.00%> (ø)
services/decoration.py 100.00% <100.00%> (ø)
services/tests/test_decoration.py 96.53% <100.00%> (+0.30%) ⬆️
Related Entrypoints
run/app.tasks.notify.Notify

)

report = ReportFactory.create(commit=commit)
for i in range(2499):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How long does this test take? I wonder if there's an easier way to mock this 😅

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eh it added a quarter of a second on a pytest run with and without it in my docker container 🤷

Copy link
Contributor

@adrian-codecov adrian-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall lgtm! Optional suggestion otherwise gtg

@codecov-qa
Copy link

codecov-qa bot commented Nov 1, 2023

Codecov Report

Merging #166 (6d93709) into main (8b81626) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #166   +/-   ##
=======================================
  Coverage   98.38%   98.38%           
=======================================
  Files         348      348           
  Lines       27607    27639   +32     
=======================================
+ Hits        27160    27192   +32     
  Misses        447      447           
Flag Coverage Δ
integration 98.38% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 98.38% <100.00%> (+<0.01%) ⬆️
unit 98.38% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.87% <100.00%> (+<0.01%) ⬆️
OutsideTasks 98.16% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
services/billing.py 100.00% <100.00%> (ø)
services/decoration.py 100.00% <100.00%> (ø)
services/tests/test_decoration.py 96.53% <100.00%> (+0.30%) ⬆️

@JerrySentry JerrySentry merged commit 164ee64 into main Nov 1, 2023
27 of 28 checks passed
@JerrySentry JerrySentry deleted the worker_639 branch November 1, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants