Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update announcements section of PR comment #165

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

scott-codecov
Copy link
Contributor

Resolves codecov/engineering-team#475

Show the ATS message to applicable repos only and otherwise show info about the browser extension.

  • announcements section will still show up to 25% of PR comments that do not have the comment layout overridden in their YAML
  • if the ATS announcement applies to the comment then favor that:
    • must not be using ATS already
    • must be a Python repo
    • must have sufficiently large chunks size
  • otherwise fallback to one of the other general announcements (currently just the browser comment announcement)

Show the ATS message to applicable repos only and otherwise
show info about browser extension.
@codecov-staging
Copy link

codecov-staging bot commented Nov 1, 2023

Codecov Report

Merging #165 (4e2febb) into main (55ec0a7) will decrease coverage by 0.01%.
The diff coverage is 92.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #165      +/-   ##
==========================================
- Coverage   98.38%   98.38%   -0.01%     
==========================================
  Files         348      348              
  Lines       27572    27607      +35     
==========================================
+ Hits        27128    27160      +32     
- Misses        444      447       +3     
Flag Coverage Δ
integration 98.38% <92.30%> (-0.01%) ⬇️
latest-uploader-overall 98.38% <92.30%> (-0.01%) ⬇️
unit 98.38% <92.30%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.87% <87.50%> (-0.03%) ⬇️
OutsideTasks 98.16% <92.30%> (-0.02%) ⬇️
Files Coverage Δ
.../notification/notifiers/tests/unit/test_comment.py 100.00% <100.00%> (ø)
.../notification/notifiers/mixins/message/sections.py 96.19% <87.50%> (-0.75%) ⬇️

Copy link

codecov-public-qa bot commented Nov 1, 2023

Codecov Report

Merging #165 (4e2febb) into main (55ec0a7) will decrease coverage by 0.01%.
The diff coverage is 92.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #165      +/-   ##
==========================================
- Coverage   98.38%   98.38%   -0.01%     
==========================================
  Files         348      348              
  Lines       27572    27607      +35     
==========================================
+ Hits        27128    27160      +32     
- Misses        444      447       +3     
Flag Coverage Δ
integration 98.38% <92.30%> (-0.01%) ⬇️
latest-uploader-overall 98.38% <92.30%> (-0.01%) ⬇️
unit 98.38% <92.30%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.87% <87.50%> (-0.03%) ⬇️
OutsideTasks 98.16% <92.30%> (-0.02%) ⬇️
Files Coverage Δ
.../notification/notifiers/tests/unit/test_comment.py 100.00% <100.00%> (ø)
.../notification/notifiers/mixins/message/sections.py 96.19% <87.50%> (-0.75%) ⬇️

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #165 (4e2febb) into main (55ec0a7) will decrease coverage by 0.01%.
The diff coverage is 92.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #165      +/-   ##
==========================================
- Coverage   98.35%   98.34%   -0.01%     
==========================================
  Files         374      374              
  Lines       28068    28103      +35     
==========================================
+ Hits        27605    27637      +32     
- Misses        463      466       +3     
Flag Coverage Δ
integration 98.38% <92.30%> (-0.01%) ⬇️
latest-uploader-overall 98.38% <92.30%> (-0.01%) ⬇️
unit 98.38% <92.30%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.76% <87.50%> (-0.03%) ⬇️
OutsideTasks 98.16% <92.30%> (-0.02%) ⬇️
Files Coverage Δ
.../notification/notifiers/tests/unit/test_comment.py 100.00% <100.00%> (ø)
.../notification/notifiers/mixins/message/sections.py 94.91% <87.50%> (-0.62%) ⬇️
Related Entrypoints
run/app.tasks.notify.Notify

@scott-codecov scott-codecov merged commit 8b81626 into main Nov 1, 2023
13 of 26 checks passed
@scott-codecov scott-codecov deleted the scott/annoucements-section branch November 1, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Messaging in PR comment: browser extension
2 participants