Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing double punctuation in PR message #164

Merged
merged 3 commits into from
Nov 6, 2023
Merged

Conversation

jerrodcodecov
Copy link
Contributor

Accidental double punctuation highlighted by @chadwhitacre codecov/feedback#54 (comment)

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #164 (ecb3af2) into main (ac537b8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #164   +/-   ##
=======================================
  Coverage   98.34%   98.34%           
=======================================
  Files         374      374           
  Lines       28144    28144           
=======================================
  Hits        27678    27678           
  Misses        466      466           
Flag Coverage Δ
integration 98.38% <ø> (ø)
latest-uploader-overall 98.38% <ø> (ø)
onlysomelabels 97.44% <ø> (-0.20%) ⬇️
unit 98.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.77% <ø> (ø)
OutsideTasks 98.16% <ø> (ø)
Files Coverage Δ
.../notification/notifiers/mixins/message/sections.py 94.91% <ø> (ø)
.../notification/notifiers/tests/unit/test_comment.py 100.00% <ø> (ø)

This change has been scanned for critical changes. Learn more

@codecov-staging
Copy link

codecov-staging bot commented Nov 6, 2023

Codecov Report

Merging #164 (ecb3af2) into main (ac537b8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #164   +/-   ##
=======================================
  Coverage   98.38%   98.38%           
=======================================
  Files         348      348           
  Lines       27648    27648           
=======================================
  Hits        27201    27201           
  Misses        447      447           
Flag Coverage Δ
integration 98.38% <ø> (ø)
latest-uploader-overall 98.38% <ø> (ø)
unit 98.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.87% <ø> (ø)
OutsideTasks 98.16% <ø> (ø)
Files Coverage Δ
.../notification/notifiers/mixins/message/sections.py 96.19% <ø> (ø)
.../notification/notifiers/tests/unit/test_comment.py 100.00% <ø> (ø)

@codecov-qa
Copy link

codecov-qa bot commented Nov 6, 2023

Codecov Report

Merging #164 (ecb3af2) into main (ac537b8) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #164   +/-   ##
=======================================
  Coverage   98.38%   98.38%           
=======================================
  Files         348      348           
  Lines       27648    27648           
=======================================
  Hits        27201    27201           
  Misses        447      447           
Flag Coverage Δ
integration 98.38% <ø> (ø)
latest-uploader-overall 98.38% <ø> (ø)
unit 98.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.87% <ø> (ø)
OutsideTasks 98.16% <ø> (ø)
Files Coverage Δ
.../notification/notifiers/mixins/message/sections.py 96.19% <ø> (ø)
.../notification/notifiers/tests/unit/test_comment.py 100.00% <ø> (ø)

@dana-yaish dana-yaish merged commit 0f82d3f into main Nov 6, 2023
24 checks passed
@dana-yaish dana-yaish deleted the jerrodcodecov-patch-1 branch November 6, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants