Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease archive field read timeout #162

Merged
merged 2 commits into from
Oct 27, 2023
Merged

Conversation

scott-codecov
Copy link
Contributor

@scott-codecov scott-codecov commented Oct 26, 2023

We see in the logs that we're getting valid reads after ~3 seconds (the current sleep interval) so let's decrease the total timeout (and sleep interval).

@codecov-staging
Copy link

codecov-staging bot commented Oct 26, 2023

Codecov Report

Merging #162 (cc92a59) into main (908dc15) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #162   +/-   ##
=======================================
  Coverage   98.38%   98.38%           
=======================================
  Files         348      348           
  Lines       27572    27572           
=======================================
  Hits        27128    27128           
  Misses        444      444           
Flag Coverage Δ
integration 98.38% <100.00%> (ø)
latest-uploader-overall 98.38% <100.00%> (ø)
unit 98.38% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.89% <100.00%> (ø)
OutsideTasks 98.17% <100.00%> (ø)
Files Coverage Δ
database/utils.py 96.15% <100.00%> (ø)

@codecov-qa
Copy link

codecov-qa bot commented Oct 26, 2023

Codecov Report

Merging #162 (cc92a59) into main (908dc15) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #162   +/-   ##
=======================================
  Coverage   98.38%   98.38%           
=======================================
  Files         348      348           
  Lines       27572    27572           
=======================================
  Hits        27128    27128           
  Misses        444      444           
Flag Coverage Δ
integration 98.38% <100.00%> (ø)
latest-uploader-overall 98.38% <100.00%> (ø)
unit 98.38% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.89% <100.00%> (ø)
OutsideTasks 98.17% <100.00%> (ø)
Files Coverage Δ
database/utils.py 96.15% <100.00%> (ø)

@codecov-public-qa
Copy link

codecov-public-qa bot commented Oct 26, 2023

Codecov Report

Merging #162 (cc92a59) into main (908dc15) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #162   +/-   ##
=======================================
  Coverage   98.38%   98.38%           
=======================================
  Files         348      348           
  Lines       27572    27572           
=======================================
  Hits        27128    27128           
  Misses        444      444           
Flag Coverage Δ
integration 98.38% <100.00%> (ø)
latest-uploader-overall 98.38% <100.00%> (ø)
unit 98.38% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.89% <100.00%> (ø)
OutsideTasks 98.17% <100.00%> (ø)
Files Coverage Δ
database/utils.py 96.15% <100.00%> (ø)

@scott-codecov scott-codecov changed the title Decreate archive field read timeout Decrease archive field read timeout Oct 26, 2023
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #162 (00bc692) into main (908dc15) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 00bc692 differs from pull request most recent head cc92a59. Consider uploading reports for the commit cc92a59 to get more accurate results

Changes have been made to critical files, which contain lines commonly executed in production. Learn more

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #162   +/-   ##
=======================================
  Coverage   98.35%   98.35%           
=======================================
  Files         374      374           
  Lines       28068    27996   -72     
=======================================
- Hits        27605    27535   -70     
+ Misses        463      461    -2     
Flag Coverage Δ
integration 98.39% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 98.39% <100.00%> (+<0.01%) ⬆️
onlysomelabels 97.88% <100.00%> (-0.54%) ⬇️
unit 98.39% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.79% <100.00%> (+<0.01%) ⬆️
OutsideTasks 98.18% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
database/utils.py Critical 96.25% <100.00%> (ø)

... and 4 files with indirect coverage changes

Related Entrypoints
run/app.tasks.pulls.Sync
run/app.tasks.upload.Upload
run/app.tasks.upload.UploadProcessor
run/app.tasks.archive.BackfillCommitDataToStorage

@scott-codecov scott-codecov merged commit 55ec0a7 into main Oct 27, 2023
25 checks passed
@scott-codecov scott-codecov deleted the scott/archive-field-timeout branch October 27, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants