Update deps to fix vulnerabilities #161
Conversation
Fixes: codecov/internal-issues#101 Fixes: codecov/internal-issues#102 Signed-off-by: joseph-sentry <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #161 +/- ##
=======================================
Coverage 98.38% 98.38%
=======================================
Files 350 350
Lines 27685 27685
=======================================
Hits 27238 27238
Misses 447 447
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #161 +/- ##
=======================================
Coverage 98.38% 98.38%
=======================================
Files 350 350
Lines 27685 27685
=======================================
Hits 27238 27238
Misses 447 447
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov Report
@@ Coverage Diff @@
## main #161 +/- ##
=======================================
Coverage ? 98.39%
=======================================
Files ? 348
Lines ? 27500
Branches ? 0
=======================================
Hits ? 27058
Misses ? 442
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov Report
Changes have been made to critical files, which contain lines commonly executed in production. Learn more @@ Coverage Diff @@
## main #161 +/- ##
==========================================
- Coverage 98.34% 95.73% -2.62%
==========================================
Files 376 375 -1
Lines 28181 28050 -131
==========================================
- Hits 27715 26854 -861
- Misses 466 1196 +730
Flags with carried forward coverage won't be shown. Click here to find out more.
see 71 files with indirect coverage changes This change has been scanned for critical changes. Learn more |
| @@ -33,6 +33,7 @@ SQLAlchemy | |||
| statsd | |||
| stripe | |||
| timestring | |||
| urllib3>=1.26.18 | |||
There was a problem hiding this comment.
i think this is fine, but because you updated this in shared in codecov/shared#70 you could avoid adding urllib3 to requirements.in by updating shared if you wanted to
Vulnerabilities were detected in these dependencies so we should update them to versions where they are fixed
Fixes: https://github.com/codecov/internal-issues/issues/101
Fixes: https://github.com/codecov/internal-issues/issues/102