fix 'NoneType' object is not subscriptable #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for https://l.codecov.dev/hqZ1Ci (Sentry issue) The error itself is `TypeError: 'NoneType' object is not subscriptable`. This was happening because if we don't have static analysis for a file the lines relevant for that file might be `None`, and we we're not checking this condition prior to starting to access the dict items. The fix itself is very simple, but I wanted to add type hints and better tests too, so they're in the change as well.
Codecov Report
@@ Coverage Diff @@
## main #160 +/- ##
=======================================
Coverage 98.39% 98.39%
=======================================
Files 348 348
Lines 27479 27500 +21
=======================================
+ Hits 27037 27058 +21
Misses 442 442
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #160 +/- ##
=======================================
Coverage 98.39% 98.39%
=======================================
Files 348 348
Lines 27479 27500 +21
=======================================
+ Hits 27037 27058 +21
Misses 442 442
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov Report
@@ Coverage Diff @@
## main #160 +/- ##
=======================================
Coverage 98.39% 98.39%
=======================================
Files 348 348
Lines 27479 27500 +21
=======================================
+ Hits 27037 27058 +21
Misses 442 442
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov Report
@@ Coverage Diff @@
## main #160 +/- ##
=======================================
Coverage 98.35% 98.35%
=======================================
Files 374 374
Lines 27975 27996 +21
=======================================
+ Hits 27514 27535 +21
Misses 461 461
Flags with carried forward coverage won't be shown. Click here to find out more.
|
giovanni-guidini
requested review from
dana-yaish,
scott-codecov,
joseph-sentry and
matt-codecov
joseph-sentry
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for https://l.codecov.dev/hqZ1Ci (Sentry issue)
The error itself is
TypeError: 'NoneType' object is not subscriptable.This was happening because if we don't have static analysis for a file
the lines relevant for that file might be
None, and we we're not checkingthis condition prior to starting to access the dict items.
The fix itself is very simple, but I wanted to add type hints and better
tests too, so they're in the change as well.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.