feat: add prometheus instrumentation to checkpointlogger #159
Conversation
matt-codecov
requested review from
dana-yaish,
giovanni-guidini,
scott-codecov,
rfox-codecov and
joseph-sentry
Codecov Report
@@ Coverage Diff @@
## main #159 +/- ##
==========================================
- Coverage 98.39% 98.38% -0.01%
==========================================
Files 348 348
Lines 27500 27572 +72
==========================================
+ Hits 27058 27128 +70
- Misses 442 444 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #159 +/- ##
==========================================
- Coverage 98.39% 98.38% -0.01%
==========================================
Files 348 348
Lines 27500 27572 +72
==========================================
+ Hits 27058 27128 +70
- Misses 442 444 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov Report
Changes have been made to critical files, which contain lines commonly executed in production. Learn more @@ Coverage Diff @@
## main #159 +/- ##
==========================================
- Coverage 98.35% 98.35% -0.01%
==========================================
Files 374 374
Lines 27996 28068 +72
==========================================
+ Hits 27535 27605 +70
- Misses 461 463 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov Report
@@ Coverage Diff @@
## main #159 +/- ##
==========================================
- Coverage 98.39% 98.38% -0.01%
==========================================
Files 348 348
Lines 27500 27572 +72
==========================================
+ Hits 27058 27128 +70
- Misses 442 444 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
hmm, i was not expecting this to fire when uploading from this branch to my local codecov service. i don't think i have the PEM file it needs configured |
|
re-requesting review because 5c8b6fe is juuuuuust significant enough that somebody should reaffirm
so now |
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
|
expected, the serialization format of checkpoints data changed so new worker versions and old worker versions disagree |
mirror
CheckpointLoggerdata in prometheus, once this is flowing we can delete the statsd/sentry stuffLegal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.