fix: define __le__ instead of just __lt__ for BaseFlow #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scott-codecov
approved these changes
Oct 24, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #157 +/- ##
==========================================
- Coverage 98.42% 98.41% -0.02%
==========================================
Files 348 348
Lines 27421 27433 +12
==========================================
+ Hits 26990 26998 +8
- Misses 431 435 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov Report
@@ Coverage Diff @@
## main #157 +/- ##
==========================================
- Coverage 98.38% 98.37% -0.02%
==========================================
Files 374 374
Lines 27917 27929 +12
==========================================
+ Hits 27467 27475 +8
- Misses 450 454 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
This change has been scanned for critical changes. Learn more |
Codecov Report
@@ Coverage Diff @@
## main #157 +/- ##
==========================================
- Coverage 98.42% 98.41% -0.02%
==========================================
Files 348 348
Lines 27421 27433 +12
==========================================
+ Hits 26990 26998 +8
- Misses 431 435 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tested by running real uploads through my local service instead of relying on unit tests and staging. i'll make sure to do that more in the future as these bugs were easily catchable before PR time if i were more diligent
i read somewhere that defining
__gt__and__eq__should fill in for other comparison functions if they aren't defined. i saw that wasn't true for__lt__in the last bugfix and defined that one manually, but i thought surely__lt__and__eq__are enough to define__le__and did not verifyLegal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.