-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update httpx and httpcore #154
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming tests pass, looks good to me.
Codecov Report
@@ Coverage Diff @@
## main #154 +/- ##
==========================================
- Coverage 98.43% 98.43% -0.01%
==========================================
Files 347 346 -1
Lines 27281 27069 -212
==========================================
- Hits 26855 26645 -210
+ Misses 426 424 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #154 +/- ##
=======================================
Coverage 98.43% 98.43%
=======================================
Files 347 347
Lines 27281 27281
=======================================
Hits 26855 26855
Misses 426 426
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov Report
@@ Coverage Diff @@
## main #154 +/- ##
=======================================
Coverage 98.43% 98.43%
=======================================
Files 347 347
Lines 27281 27281
=======================================
Hits 26855 26855
Misses 426 426
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov Report
@@ Coverage Diff @@
## main #154 +/- ##
=======================================
Coverage 98.40% 98.40%
=======================================
Files 373 373
Lines 27860 27860
=======================================
Hits 27417 27417
Misses 443 443
Flags with carried forward coverage won't be shown. Click here to find out more.
This change has been scanned for critical changes. Learn more |
I think we were running into this bug encode/httpcore#564 (as seen here: https://codecov.sentry.io/issues/4463071748)
The fix was implemented in
httpcore 0.16.0
: encode/httpcore#580. I updatedhttpx
andhttpcore
to incorporate that fix.Sounds like the alternative is to use
asyncio.TaskGroup
s (which are available in Python 3.11) instead ofasyncio.gather
(which cancel the other tasks in the group when an exception arises in one of them)