adding try except to catch any unexpected errors #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #147 +/- ##
==========================================
- Coverage 98.43% 98.43% -0.01%
==========================================
Files 347 347
Lines 27281 27287 +6
==========================================
+ Hits 26855 26859 +4
- Misses 426 428 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov Report
@@ Coverage Diff @@
## main #147 +/- ##
==========================================
- Coverage 98.43% 98.43% -0.01%
==========================================
Files 347 347
Lines 27281 27287 +6
==========================================
+ Hits 26855 26859 +4
- Misses 426 428 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov Report
@@ Coverage Diff @@
## main #147 +/- ##
==========================================
- Coverage 98.40% 98.39% -0.02%
==========================================
Files 373 373
Lines 27860 27783 -77
==========================================
- Hits 27417 27336 -81
- Misses 443 447 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes This change has been scanned for critical changes. Learn more |
dana-yaish
force-pushed
the
dana/except-timeseries-exceptions
branch
from
6a5db5f
to
d156a64
Compare
dana-yaish
force-pushed
the
dana/except-timeseries-exceptions
branch
from
d156a64
to
2fe51d7
Compare
scott-codecov
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upload finisher is being retried mutiple times because of a raised error in timeseries. Adding a try-except block to catch any errors
https://github.com/codecov/internal-issues/issues/97
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.