Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry archive field read during timeout window #146

Merged
merged 2 commits into from
Oct 17, 2023

Conversation

scott-codecov
Copy link
Contributor

codecov/engineering-team#420

Retry reading from archive storage for archive fields. If we find the missing file after a delay then we know there is some kind of race condition going on.

@codecov-qa
Copy link

codecov-qa bot commented Oct 13, 2023

Codecov Report

Merging #146 (b1118ab) into main (0b2f919) will decrease coverage by 0.01%.
The diff coverage is 96.15%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #146      +/-   ##
==========================================
- Coverage   98.44%   98.44%   -0.01%     
==========================================
  Files         347      347              
  Lines       27230    27248      +18     
==========================================
+ Hits        26806    26823      +17     
- Misses        424      425       +1     
Flag Coverage Δ
integration 98.44% <96.15%> (-0.01%) ⬇️
latest-uploader-overall 98.44% <96.15%> (-0.01%) ⬇️
unit 98.44% <96.15%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.99% <94.73%> (-0.01%) ⬇️
OutsideTasks 98.23% <96.15%> (-0.01%) ⬇️
Files Coverage Δ
database/tests/unit/test_model_utils.py 100.00% <100.00%> (ø)
database/tests/unit/test_models.py 100.00% <100.00%> (ø)
database/utils.py 96.15% <94.73%> (-0.73%) ⬇️

@codecov-public-qa
Copy link

codecov-public-qa bot commented Oct 13, 2023

Codecov Report

Merging #146 (b1118ab) into main (0b2f919) will decrease coverage by 0.01%.
The diff coverage is 96.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #146      +/-   ##
==========================================
- Coverage   98.44%   98.44%   -0.01%     
==========================================
  Files         347      347              
  Lines       27230    27248      +18     
==========================================
+ Hits        26806    26823      +17     
- Misses        424      425       +1     
Flag Coverage Δ
integration 98.44% <96.15%> (-0.01%) ⬇️
latest-uploader-overall 98.44% <96.15%> (-0.01%) ⬇️
unit 98.44% <96.15%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.99% <94.73%> (-0.01%) ⬇️
OutsideTasks 98.23% <96.15%> (-0.01%) ⬇️
Files Coverage Δ
database/tests/unit/test_model_utils.py 100.00% <100.00%> (ø)
database/tests/unit/test_models.py 100.00% <100.00%> (ø)
database/utils.py 96.15% <94.73%> (-0.73%) ⬇️

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #146 (b1118ab) into main (0b2f919) will decrease coverage by 0.01%.
The diff coverage is 96.15%.

Changes have been made to critical files, which contain lines commonly executed in production. Learn more

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #146      +/-   ##
==========================================
- Coverage   98.40%   98.39%   -0.01%     
==========================================
  Files         373      373              
  Lines       27726    27744      +18     
==========================================
+ Hits        27283    27300      +17     
- Misses        443      444       +1     
Flag Coverage Δ
integration 98.44% <96.15%> (-0.01%) ⬇️
latest-uploader-overall 98.44% <96.15%> (-0.01%) ⬇️
unit 98.44% <96.15%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.89% <94.73%> (-0.01%) ⬇️
OutsideTasks 98.23% <96.15%> (-0.01%) ⬇️
Files Coverage Δ
database/tests/unit/test_model_utils.py 100.00% <100.00%> (ø)
database/tests/unit/test_models.py 100.00% <100.00%> (ø)
database/utils.py Critical 96.25% <94.73%> (-0.72%) ⬇️
Related Entrypoints
run/app.tasks.pulls.Sync
run/app.tasks.notify.Notify
run/app.tasks.upload.Upload
run/app.tasks.compute_comparison.ComputeComparison
run/app.tasks.upload.UploadFinisher
run/app.tasks.upload.UploadProcessor
run/app.tasks.label_analysis.process_request
run/app.tasks.timeseries.backfill_commits

@scott-codecov scott-codecov merged commit dc65d63 into main Oct 17, 2023
13 of 26 checks passed
@scott-codecov scott-codecov deleted the scott/retry-archive-field-read branch October 17, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants