Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding log #139

Merged
merged 4 commits into from
Oct 11, 2023
Merged

adding log #139

merged 4 commits into from
Oct 11, 2023

Conversation

dana-yaish
Copy link
Contributor

this is the first step in debugging why the upload finisher gets executed multiple times by different worker pods

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-qa
Copy link

codecov-qa bot commented Oct 5, 2023

Codecov Report

Merging #139 (6dfa2ca) into main (33030c4) will decrease coverage by 0.01%.
The diff coverage is 85.71%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #139      +/-   ##
==========================================
- Coverage   98.44%   98.43%   -0.01%     
==========================================
  Files         347      347              
  Lines       27223    27226       +3     
==========================================
+ Hits        26800    26801       +1     
- Misses        423      425       +2     
Flag Coverage Δ
integration 98.43% <85.71%> (-0.01%) ⬇️
latest-uploader-overall 98.43% <85.71%> (-0.01%) ⬇️
unit 98.43% <85.71%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.99% <85.71%> (-0.02%) ⬇️
OutsideTasks 98.23% <ø> (ø)
Files Coverage Δ
tasks/upload_finisher.py 95.45% <85.71%> (-1.75%) ⬇️

@codecov-public-qa
Copy link

codecov-public-qa bot commented Oct 5, 2023

Codecov Report

Merging #139 (6dfa2ca) into main (33030c4) will decrease coverage by 0.01%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #139      +/-   ##
==========================================
- Coverage   98.44%   98.43%   -0.01%     
==========================================
  Files         347      347              
  Lines       27223    27226       +3     
==========================================
+ Hits        26800    26801       +1     
- Misses        423      425       +2     
Flag Coverage Δ
integration 98.43% <85.71%> (-0.01%) ⬇️
latest-uploader-overall 98.43% <85.71%> (-0.01%) ⬇️
unit 98.43% <85.71%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.99% <85.71%> (-0.02%) ⬇️
OutsideTasks 98.23% <ø> (ø)
Files Coverage Δ
tasks/upload_finisher.py 95.45% <85.71%> (-1.75%) ⬇️

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #139 (6dfa2ca) into main (33030c4) will decrease coverage by 0.01%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #139      +/-   ##
==========================================
- Coverage   98.40%   98.39%   -0.01%     
==========================================
  Files         373      373              
  Lines       27719    27722       +3     
==========================================
+ Hits        27277    27278       +1     
- Misses        442      444       +2     
Flag Coverage Δ
integration 98.43% <85.71%> (-0.01%) ⬇️
latest-uploader-overall 98.43% <85.71%> (-0.01%) ⬇️
unit 98.43% <85.71%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.88% <85.71%> (-0.02%) ⬇️
OutsideTasks 98.23% <ø> (ø)
Files Coverage Δ
tasks/upload_finisher.py 95.49% <85.71%> (-1.73%) ⬇️
Related Entrypoints
run/app.tasks.upload.UploadFinisher

Copy link
Contributor

@giovanni-guidini giovanni-guidini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tasks/upload_finisher.py Outdated Show resolved Hide resolved
@dana-yaish dana-yaish merged commit 21d7b70 into main Oct 11, 2023
16 of 26 checks passed
@dana-yaish dana-yaish deleted the dana/finisher-log branch October 11, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants