Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to not add health check task to celery beat schedule #133

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

joseph-sentry
Copy link
Contributor

@codecov-staging
Copy link

codecov-staging bot commented Oct 4, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@dd4d0eb). Click here to learn what that means.
The diff coverage is 50.00%.

❗ Current head 2feec11 differs from pull request most recent head 50cc935. Consider uploading reports for the commit 50cc935 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #133   +/-   ##
=======================================
  Coverage        ?   93.25%           
=======================================
  Files           ?      346           
  Lines           ?    26891           
  Branches        ?        0           
=======================================
  Hits            ?    25076           
  Misses          ?     1815           
  Partials        ?        0           
Flag Coverage Δ
integration 93.25% <50.00%> (?)
latest-uploader-overall 93.25% <50.00%> (?)
unit 93.25% <50.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 93.95% <50.00%> (?)
OutsideTasks 96.71% <50.00%> (?)
Files Coverage Δ
celery_config.py 66.15% <50.00%> (ø)

@codecov-qa
Copy link

codecov-qa bot commented Oct 4, 2023

Codecov Report

Merging #133 (8ad304a) into main (0ff20ab) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #133      +/-   ##
==========================================
- Coverage   98.44%   98.44%   -0.01%     
==========================================
  Files         347      347              
  Lines       27221    27223       +2     
==========================================
+ Hits        26799    26800       +1     
- Misses        422      423       +1     
Flag Coverage Δ
integration 98.44% <50.00%> (-0.01%) ⬇️
latest-uploader-overall 98.44% <50.00%> (-0.01%) ⬇️
unit 98.44% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 97.01% <50.00%> (-0.01%) ⬇️
OutsideTasks 98.23% <50.00%> (-0.01%) ⬇️
Files Coverage Δ
celery_config.py 66.15% <50.00%> (-0.52%) ⬇️

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #133 (8ad304a) into main (0ff20ab) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #133      +/-   ##
==========================================
- Coverage   98.40%   98.40%   -0.01%     
==========================================
  Files         373      373              
  Lines       27717    27719       +2     
==========================================
+ Hits        27276    27277       +1     
- Misses        441      442       +1     
Flag Coverage Δ
integration 98.44% <50.00%> (-0.01%) ⬇️
latest-uploader-overall 98.44% <50.00%> (-0.01%) ⬇️
unit 98.44% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.90% <50.00%> (-0.01%) ⬇️
OutsideTasks 98.23% <50.00%> (-0.01%) ⬇️
Files Coverage Δ
celery_config.py 66.15% <50.00%> (-0.52%) ⬇️

This change has been scanned for critical changes. Learn more

@joseph-sentry joseph-sentry marked this pull request as ready for review October 4, 2023 18:25
@codecov-public-qa
Copy link

codecov-public-qa bot commented Oct 5, 2023

Codecov Report

Merging #133 (8ad304a) into main (0ff20ab) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #133      +/-   ##
==========================================
- Coverage   98.44%   98.44%   -0.01%     
==========================================
  Files         347      347              
  Lines       27221    27223       +2     
==========================================
+ Hits        26799    26800       +1     
- Misses        422      423       +1     
Flag Coverage Δ
integration 98.44% <50.00%> (-0.01%) ⬇️
latest-uploader-overall 98.44% <50.00%> (-0.01%) ⬇️
unit 98.44% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 97.01% <50.00%> (-0.01%) ⬇️
OutsideTasks 98.23% <50.00%> (-0.01%) ⬇️
Files Coverage Δ
celery_config.py 66.15% <50.00%> (-0.52%) ⬇️

Copy link
Contributor

@dana-yaish dana-yaish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joseph-sentry joseph-sentry force-pushed the joseph/healthcheck-schedule branch 2 times, most recently from 50cc935 to caefd56 Compare October 10, 2023 08:22
@joseph-sentry joseph-sentry merged commit 33030c4 into main Oct 10, 2023
11 of 24 checks passed
@joseph-sentry joseph-sentry deleted the joseph/healthcheck-schedule branch October 10, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to disable healthcheck task
2 participants