Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating header based on product team feedback #128

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

dana-yaish
Copy link
Contributor

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@dana-yaish dana-yaish linked an issue Oct 2, 2023 that may be closed by this pull request
@codecov-staging
Copy link

codecov-staging bot commented Oct 2, 2023

Codecov Report

Merging #128 (a2b0c6c) into main (d5d1155) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #128   +/-   ##
=======================================
  Coverage   93.25%   93.25%           
=======================================
  Files         346      346           
  Lines       26889    26889           
=======================================
  Hits        25075    25075           
  Misses       1814     1814           
Flag Coverage Δ
integration 93.25% <100.00%> (ø)
latest-uploader-overall 93.25% <100.00%> (ø)
unit 93.25% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 93.96% <100.00%> (ø)
OutsideTasks 96.72% <100.00%> (ø)
Files Coverage Δ
.../notification/notifiers/mixins/message/sections.py 96.25% <100.00%> (ø)
...cation/notifiers/tests/integration/test_comment.py 18.57% <ø> (ø)
.../notification/notifiers/tests/unit/test_comment.py 100.00% <ø> (ø)

@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Merging #128 (a2b0c6c) into main (d5d1155) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #128   +/-   ##
=======================================
  Coverage   98.46%   98.46%           
=======================================
  Files         369      369           
  Lines       27233    27233           
=======================================
  Hits        26814    26814           
  Misses        419      419           
Flag Coverage Δ
integration 98.43% <100.00%> (ø)
latest-uploader-overall 98.43% <100.00%> (ø)
unit 98.43% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 97.05% <100.00%> (ø)
OutsideTasks 98.22% <100.00%> (ø)
Files Coverage Δ
.../notification/notifiers/mixins/message/sections.py 95.52% <100.00%> (ø)
...cation/notifiers/tests/integration/test_comment.py 92.34% <ø> (ø)
.../notification/notifiers/tests/unit/test_comment.py 100.00% <ø> (ø)
Related Entrypoints
run/app.tasks.notify.Notify

@codecov-public-qa
Copy link

codecov-public-qa bot commented Oct 2, 2023

Codecov Report

Merging #128 (a2b0c6c) into main (d5d1155) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #128   +/-   ##
=======================================
  Coverage   93.25%   93.25%           
=======================================
  Files         346      346           
  Lines       26889    26889           
=======================================
  Hits        25075    25075           
  Misses       1814     1814           
Flag Coverage Δ
integration 93.25% <100.00%> (ø)
latest-uploader-overall 93.25% <100.00%> (ø)
unit 93.25% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 93.96% <100.00%> (ø)
OutsideTasks 96.72% <100.00%> (ø)
Files Changed Coverage Δ
...cation/notifiers/tests/integration/test_comment.py 18.57% <ø> (ø)
.../notification/notifiers/tests/unit/test_comment.py 100.00% <ø> (ø)
.../notification/notifiers/mixins/message/sections.py 96.25% <100.00%> (ø)

@dana-yaish dana-yaish merged commit cf2f06a into main Oct 3, 2023
30 of 32 checks passed
@dana-yaish dana-yaish deleted the dana/update-header branch October 3, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update copy for summary
2 participants