Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add preprocess upload task to celery task router #124

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

dana-yaish
Copy link
Contributor

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Merging #124 (b4a285f) into main (c447740) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #124   +/-   ##
=======================================
  Coverage   98.45%   98.45%           
=======================================
  Files         364      364           
  Lines       26989    26989           
=======================================
  Hits        26571    26571           
  Misses        418      418           
Flag Coverage Δ
integration 98.41% <ø> (?)
latest-uploader-overall 98.41% <ø> (?)
onlysomelabels 98.45% <ø> (ø)
unit 98.41% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 97.03% <ø> (ø)
OutsideTasks 98.20% <ø> (∅)
Files Coverage Δ
celery_task_router.py 100.00% <ø> (ø)

This change has been scanned for critical changes. Learn more

@codecov-staging
Copy link

codecov-staging bot commented Sep 29, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@c447740). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #124   +/-   ##
=======================================
  Coverage        ?   93.19%           
=======================================
  Files           ?      341           
  Lines           ?    26645           
  Branches        ?        0           
=======================================
  Hits            ?    24832           
  Misses          ?     1813           
  Partials        ?        0           
Flag Coverage Δ
integration 93.19% <ø> (?)
latest-uploader-overall 93.19% <ø> (?)
unit 93.19% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 93.91% <ø> (?)
OutsideTasks 96.68% <ø> (?)
Files Coverage Δ
celery_task_router.py 100.00% <ø> (ø)

@codecov-public-qa
Copy link

codecov-public-qa bot commented Sep 29, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@c447740). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #124   +/-   ##
=======================================
  Coverage        ?   93.19%           
=======================================
  Files           ?      341           
  Lines           ?    26645           
  Branches        ?        0           
=======================================
  Hits            ?    24832           
  Misses          ?     1813           
  Partials        ?        0           
Flag Coverage Δ
integration 93.19% <ø> (?)
latest-uploader-overall 93.19% <ø> (?)
unit 93.19% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 93.91% <ø> (?)
OutsideTasks 96.68% <ø> (?)
Files Changed Coverage Δ
celery_task_router.py 100.00% <ø> (ø)

@dana-yaish dana-yaish merged commit 25855a7 into main Sep 29, 2023
32 checks passed
@dana-yaish dana-yaish deleted the dana/preprocess-to-task-router branch September 29, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants