-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardizing CI #119
Standardizing CI #119
Conversation
Codecov Report
@@ Coverage Diff @@
## main #119 +/- ##
=======================================
Coverage 98.45% 98.45%
=======================================
Files 364 364
Lines 26984 26989 +5
=======================================
+ Hits 26566 26571 +5
Misses 418 418
Flags with carried forward coverage won't be shown. Click here to find out more.
This change has been scanned for critical changes. Learn more |
Codecov Report
@@ Coverage Diff @@
## main #119 +/- ##
==========================================
- Coverage 98.41% 93.19% -5.23%
==========================================
Files 341 341
Lines 26640 26645 +5
==========================================
- Hits 26219 24832 -1387
- Misses 421 1813 +1392
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov Report
@@ Coverage Diff @@
## main #119 +/- ##
==========================================
- Coverage 98.41% 93.19% -5.23%
==========================================
Files 341 341
Lines 26640 26645 +5
==========================================
- Hits 26219 24832 -1387
- Misses 421 1813 +1392
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why did you have to update tests?
$(shell codecovcli label-analysis --base-sha=${merge_sha} --token=${CODECOV_STATIC_TOKEN} --dry-run --dry-run-output-path=tests_to_run > /dev/null) | ||
sed -i 's/--cov-context=test//g' tests_to_run | ||
sed -i 's/\s\+/\n/g' tests_to_run | ||
python -m pytest --cov=./ --cov-context=test `cat tests_to_run` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this munging added for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is doing a bit of hackery to use the dry run output for ATS. This will go away with some changes Gio is working on this sprint.
Tests were updated due to using the dry run output for label analysis. It made some of the tests never possible. Short context: Any test with dynamic params that will be different at runtime (time based for ex) will cause a pytest error. These changes are stop gaps until a more robust solution to this problem is implemented. |
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.