Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardizing CI #119

Merged
merged 6 commits into from
Sep 28, 2023
Merged

Standardizing CI #119

merged 6 commits into from
Sep 28, 2023

Conversation

trent-codecov
Copy link
Contributor

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #119 (a79033c) into main (68f9fa1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #119   +/-   ##
=======================================
  Coverage   98.45%   98.45%           
=======================================
  Files         364      364           
  Lines       26984    26989    +5     
=======================================
+ Hits        26566    26571    +5     
  Misses        418      418           
Flag Coverage Δ
integration 93.19% <100.00%> (-5.23%) ⬇️
latest-uploader-overall 93.19% <100.00%> (-5.23%) ⬇️
onlysomelabels 98.45% <100.00%> (+<0.01%) ⬆️
unit 93.19% <100.00%> (-5.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 97.03% <ø> (ø)
OutsideTasks 96.68% <100.00%> (-1.52%) ⬇️
Files Coverage Δ
services/path_fixer/tests/unit/test_fixpaths.py 100.00% <100.00%> (ø)
...vices/report/languages/tests/unit/test_bullseye.py 97.14% <ø> (ø)
...ervices/report/languages/tests/unit/test_clover.py 100.00% <100.00%> (ø)
...ices/report/languages/tests/unit/test_cobertura.py 100.00% <100.00%> (ø)
...ervices/report/languages/tests/unit/test_jacoco.py 100.00% <100.00%> (ø)

This change has been scanned for critical changes. Learn more

@codecov-staging
Copy link

codecov-staging bot commented Sep 28, 2023

Codecov Report

Merging #119 (a79033c) into main (68f9fa1) will decrease coverage by 5.23%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #119      +/-   ##
==========================================
- Coverage   98.41%   93.19%   -5.23%     
==========================================
  Files         341      341              
  Lines       26640    26645       +5     
==========================================
- Hits        26219    24832    -1387     
- Misses        421     1813    +1392     
Flag Coverage Δ
integration 93.19% <100.00%> (-5.23%) ⬇️
latest-uploader-overall 93.19% <100.00%> (-5.23%) ⬇️
unit 93.19% <100.00%> (-5.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 93.91% <ø> (-3.06%) ⬇️
OutsideTasks 96.68% <100.00%> (-1.52%) ⬇️
Files Coverage Δ
services/path_fixer/tests/unit/test_fixpaths.py 100.00% <100.00%> (ø)
...vices/report/languages/tests/unit/test_bullseye.py 97.14% <ø> (ø)
...ervices/report/languages/tests/unit/test_clover.py 100.00% <100.00%> (ø)
...ices/report/languages/tests/unit/test_cobertura.py 100.00% <100.00%> (ø)
...ervices/report/languages/tests/unit/test_jacoco.py 100.00% <100.00%> (ø)

... and 47 files with indirect coverage changes

@codecov-public-qa
Copy link

codecov-public-qa bot commented Sep 28, 2023

Codecov Report

Merging #119 (a79033c) into main (68f9fa1) will decrease coverage by 5.23%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #119      +/-   ##
==========================================
- Coverage   98.41%   93.19%   -5.23%     
==========================================
  Files         341      341              
  Lines       26640    26645       +5     
==========================================
- Hits        26219    24832    -1387     
- Misses        421     1813    +1392     
Flag Coverage Δ
integration 93.19% <100.00%> (-5.23%) ⬇️
latest-uploader-overall 93.19% <100.00%> (-5.23%) ⬇️
unit 93.19% <100.00%> (-5.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 93.91% <ø> (-3.06%) ⬇️
OutsideTasks 96.68% <100.00%> (-1.52%) ⬇️
Files Changed Coverage Δ
...vices/report/languages/tests/unit/test_bullseye.py 97.14% <ø> (ø)
services/path_fixer/tests/unit/test_fixpaths.py 100.00% <100.00%> (ø)
...ervices/report/languages/tests/unit/test_clover.py 100.00% <100.00%> (ø)
...ices/report/languages/tests/unit/test_cobertura.py 100.00% <100.00%> (ø)
...ervices/report/languages/tests/unit/test_jacoco.py 100.00% <100.00%> (ø)

... and 47 files with indirect coverage changes

@trent-codecov trent-codecov marked this pull request as ready for review September 28, 2023 04:05
Copy link
Contributor

@matt-codecov matt-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did you have to update tests?

Comment on lines +227 to +230
$(shell codecovcli label-analysis --base-sha=${merge_sha} --token=${CODECOV_STATIC_TOKEN} --dry-run --dry-run-output-path=tests_to_run > /dev/null)
sed -i 's/--cov-context=test//g' tests_to_run
sed -i 's/\s\+/\n/g' tests_to_run
python -m pytest --cov=./ --cov-context=test `cat tests_to_run`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this munging added for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is doing a bit of hackery to use the dry run output for ATS. This will go away with some changes Gio is working on this sprint.

@trent-codecov
Copy link
Contributor Author

Tests were updated due to using the dry run output for label analysis. It made some of the tests never possible.

Short context: Any test with dynamic params that will be different at runtime (time based for ex) will cause a pytest error. These changes are stop gaps until a more robust solution to this problem is implemented.

Slack context

@trent-codecov trent-codecov merged commit c447740 into main Sep 28, 2023
25 of 32 checks passed
@trent-codecov trent-codecov deleted the feature/self-hosted-release-revamp branch September 28, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants