chore: add warning if only special labels in report #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Changes have been made to critical files, which contain lines commonly executed in production. Learn more @@ Coverage Diff @@
## main #116 +/- ##
==========================================
+ Coverage 98.45% 98.49% +0.04%
==========================================
Files 364 364
Lines 26980 27522 +542
==========================================
+ Hits 26562 27108 +546
+ Misses 418 414 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes This change has been scanned for critical changes. Learn more |
After merging #113 I decided to investigate a little more why we would receive nothing but SpecialLabels in a report. Turns out that if you generate the reports without `--cov-context=test` but do `coverage json --show-contexts` it does that. So having a report with only special labels might indicate that ATS is not properly configured, that is, the tests are not running as they should. Ideally we would have a better place to surface this to customers, but right now we don't. So the least we can do is add a warning. In this case, if we look at all the logs in the task, we will see this detail.
giovanni-guidini
force-pushed
the
gio/add-warning-if-all-special-labels
branch
from
072f9ae
to
1de29b3
Compare
Codecov Report
@@ Coverage Diff @@
## main #116 +/- ##
=======================================
Coverage 98.41% 98.41%
=======================================
Files 341 341
Lines 26636 26640 +4
=======================================
+ Hits 26215 26219 +4
Misses 421 421
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov Report
@@ Coverage Diff @@
## main #116 +/- ##
=======================================
Coverage 98.41% 98.41%
=======================================
Files 341 341
Lines 26636 26640 +4
=======================================
+ Hits 26215 26219 +4
Misses 421 421
Flags with carried forward coverage won't be shown. Click here to find out more.
|
scott-codecov
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After merging #113 I decided to investigate a little more why we would receive nothing but SpecialLabels in a report.
Turns out that if you generate the reports without
--cov-context=testbut docoverage json --show-contextsit does that.So having a report with only special labels might indicate that ATS is not properly configured,
that is, the tests are not running as they should.
Ideally we would have a better place to surface this to customers, but right now we don't.
So the least we can do is add a warning. In this case, if we look at all the logs in the task,
we will see this detail.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.