create new files section #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dana-yaish
commented
Sep 21, 2023
| @@ -190,7 +190,7 @@ def get_middle_layout_section_names(self, settings): | |||
| return [ | |||
| section | |||
| for section in sections | |||
| if section not in ["header", "newheader", "newfooter"] | |||
| if section not in ["header", "newheader", "newfooter", "newfiles"] | |||
There was a problem hiding this comment.
adding this here because the new designs take out the files section from the drop down part
Codecov Report
@@ Coverage Diff @@
## main #109 +/- ##
==========================================
+ Coverage 98.47% 98.48% +0.01%
==========================================
Files 364 364
Lines 26863 27412 +549
==========================================
+ Hits 26453 26997 +544
- Misses 410 415 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov Report
@@ Coverage Diff @@
## main #109 +/- ##
==========================================
- Coverage 98.43% 98.42% -0.02%
==========================================
Files 343 343
Lines 26691 26703 +12
==========================================
+ Hits 26274 26283 +9
- Misses 417 420 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov Report
@@ Coverage Diff @@
## main #109 +/- ##
==========================================
- Coverage 98.43% 98.42% -0.02%
==========================================
Files 343 343
Lines 26691 26703 +12
==========================================
+ Hits 26274 26283 +9
- Misses 417 420 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
joseph-sentry
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR separates the legacy files table format and the new files table format. This way is cleaner that having if conditions all over the class and makes it easy to take the files section out of the drop down part
You can look at the designs here
Note that we're experimenting the new format with users by overriding their comment section in their yamls. After deploying this change, we'll need to change the overrode yaml from
layout: "newheader, diff, flags, files, feedback, newfooter"tolayout: "newheader, diff, flags, newfiles, feedback, newfooter"depends on codecov/shared#43
after merging it, need to update the shared version in requirements
tested these changes in a PR
before changes:
after changes:
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.