Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove add_to_sendgrid_list task and related information #108

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

joseph-sentry
Copy link
Contributor

No description provided.

@joseph-sentry joseph-sentry marked this pull request as ready for review September 21, 2023 15:06
@codecov-staging
Copy link

codecov-staging bot commented Sep 21, 2023

Codecov Report

Merging #108 (01ec67a) into main (2836ea9) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #108      +/-   ##
==========================================
- Coverage   98.42%   98.41%   -0.01%     
==========================================
  Files         343      341       -2     
  Lines       26703    26636      -67     
==========================================
- Hits        26283    26215      -68     
- Misses        420      421       +1     
Flag Coverage Δ
integration 98.41% <ø> (-0.01%) ⬇️
latest-uploader-overall 98.41% <ø> (-0.01%) ⬇️
unit 98.41% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.96% <ø> (-0.02%) ⬇️
OutsideTasks 98.20% <ø> (-0.01%) ⬇️
Files Coverage Δ
celery_task_router.py 100.00% <ø> (ø)
tasks/__init__.py 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

@codecov-public-qa
Copy link

codecov-public-qa bot commented Sep 21, 2023

Codecov Report

Merging #108 (01ec67a) into main (2836ea9) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #108      +/-   ##
==========================================
- Coverage   98.42%   98.41%   -0.01%     
==========================================
  Files         343      341       -2     
  Lines       26703    26636      -67     
==========================================
- Hits        26283    26215      -68     
- Misses        420      421       +1     
Flag Coverage Δ
integration 98.41% <ø> (-0.01%) ⬇️
latest-uploader-overall 98.41% <ø> (-0.01%) ⬇️
unit 98.41% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.96% <ø> (-0.02%) ⬇️
OutsideTasks 98.20% <ø> (-0.01%) ⬇️
Files Changed Coverage Δ
celery_task_router.py 100.00% <ø> (ø)
tasks/__init__.py 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #108 (01ec67a) into main (2836ea9) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #108      +/-   ##
==========================================
- Coverage   98.45%   98.45%   -0.01%     
==========================================
  Files         364      364              
  Lines       26981    26980       -1     
==========================================
- Hits        26563    26562       -1     
  Misses        418      418              
Flag Coverage Δ
integration 98.41% <ø> (-0.01%) ⬇️
latest-uploader-overall 98.41% <ø> (-0.01%) ⬇️
onlysomelabels 98.45% <ø> (-0.01%) ⬇️
unit 98.41% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 97.03% <ø> (-0.01%) ⬇️
OutsideTasks 98.20% <ø> (-0.01%) ⬇️
Files Coverage Δ
celery_task_router.py 100.00% <ø> (ø)
tasks/__init__.py 100.00% <ø> (ø)

This change has been scanned for critical changes. Learn more

Copy link
Contributor

@giovanni-guidini giovanni-guidini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that we will update this with some other task, so looks good.

Please remember to check that we are, in fact, not using this prior to merging; and there's some info related to this task in shared as well.

@joseph-sentry joseph-sentry force-pushed the joseph/remove-add-to-sendgrid-list branch from 67559e9 to 102d87b Compare September 25, 2023 17:12
@joseph-sentry joseph-sentry force-pushed the joseph/remove-add-to-sendgrid-list branch from 102d87b to 01ec67a Compare September 26, 2023 14:20
@joseph-sentry joseph-sentry merged commit b1ff653 into main Sep 27, 2023
25 of 31 checks passed
@joseph-sentry joseph-sentry deleted the joseph/remove-add-to-sendgrid-list branch September 27, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants