fix bug when there's changed files, but none have missing cov lines #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dana-yaish
force-pushed
the
dana/no-missing-lines-bug
branch
from
7bb7d3a
to
5645820
Compare
Codecov Report
@@ Coverage Diff @@
## main #105 +/- ##
=======================================
Coverage 98.46% 98.47%
=======================================
Files 364 364
Lines 26847 26855 +8
=======================================
+ Hits 26436 26445 +9
+ Misses 411 410 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov Report
@@ Coverage Diff @@
## main #105 +/- ##
=======================================
Coverage 98.43% 98.43%
=======================================
Files 343 343
Lines 26675 26683 +8
=======================================
+ Hits 26257 26266 +9
+ Misses 418 417 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov Report
@@ Coverage Diff @@
## main #105 +/- ##
=======================================
Coverage 98.43% 98.43%
=======================================
Files 343 343
Lines 26675 26683 +8
=======================================
+ Hits 26257 26266 +9
+ Misses 418 417 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
joseph-sentry
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sometimes a PR has changed files, but all changed files has patch coverage 100%. Currently, we have a bug that prints out the header without the printing anything in the table. In this case, we don't want anything to be printed out, as we only care about files with patch coverage < 100%
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.