Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

making changes to the new header section based on the designs #104

Merged
merged 4 commits into from
Sep 22, 2023

Conversation

dana-yaish
Copy link
Contributor

@dana-yaish dana-yaish commented Sep 21, 2023

This PR changes the newHeader section to follow these new designs, please look at the right part of the designs

Another PR will follow for the files section changes

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #104 (2c498ff) into main (404256e) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #104      +/-   ##
==========================================
- Coverage   98.47%   98.47%   -0.01%     
==========================================
  Files         364      364              
  Lines       26855    26837      -18     
==========================================
- Hits        26445    26427      -18     
  Misses        410      410              
Flag Coverage Δ
integration 98.43% <100.00%> (-0.01%) ⬇️
latest-uploader-overall 98.43% <100.00%> (-0.01%) ⬇️
onlysomelabels 98.47% <100.00%> (-0.01%) ⬇️
unit 98.43% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 97.10% <100.00%> (-0.01%) ⬇️
OutsideTasks 98.22% <100.00%> (-0.01%) ⬇️
Files Changed Coverage Δ
...cation/notifiers/tests/integration/test_comment.py 92.34% <ø> (ø)
.../notification/notifiers/tests/unit/test_comment.py 100.00% <ø> (ø)
.../notification/notifiers/mixins/message/sections.py 97.81% <100.00%> (-0.13%) ⬇️
Related Entrypoints
run/app.tasks.notify.Notify

@codecov-staging
Copy link

codecov-staging bot commented Sep 21, 2023

Codecov Report

Merging #104 (2c498ff) into main (404256e) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #104      +/-   ##
==========================================
- Coverage   98.43%   98.43%   -0.01%     
==========================================
  Files         343      343              
  Lines       26683    26665      -18     
==========================================
- Hits        26266    26248      -18     
  Misses        417      417              
Flag Coverage Δ
integration 98.43% <100.00%> (-0.01%) ⬇️
latest-uploader-overall 98.43% <100.00%> (-0.01%) ⬇️
unit 98.43% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 97.01% <100.00%> (-0.01%) ⬇️
OutsideTasks 98.22% <100.00%> (-0.01%) ⬇️

@codecov-public-qa
Copy link

codecov-public-qa bot commented Sep 21, 2023

Codecov Report

Merging #104 (2c498ff) into main (404256e) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #104      +/-   ##
==========================================
- Coverage   98.43%   98.43%   -0.01%     
==========================================
  Files         343      343              
  Lines       26683    26665      -18     
==========================================
- Hits        26266    26248      -18     
  Misses        417      417              
Flag Coverage Δ
integration 98.43% <100.00%> (-0.01%) ⬇️
latest-uploader-overall 98.43% <100.00%> (-0.01%) ⬇️
unit 98.43% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 97.01% <100.00%> (-0.01%) ⬇️
OutsideTasks 98.22% <100.00%> (-0.01%) ⬇️
Files Changed Coverage Δ
...cation/notifiers/tests/integration/test_comment.py 92.34% <ø> (ø)
.../notification/notifiers/tests/unit/test_comment.py 100.00% <ø> (ø)
.../notification/notifiers/mixins/message/sections.py 97.81% <100.00%> (-0.13%) ⬇️

@dana-yaish dana-yaish merged commit 3004a63 into main Sep 22, 2023
31 checks passed
@dana-yaish dana-yaish deleted the dana/new-header-changes branch September 22, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants