Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no longer set status for deleted (in UI) flags #103

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

joseph-sentry
Copy link
Contributor

@codecov-public-qa
Copy link

codecov-public-qa bot commented Sep 20, 2023

Codecov Report

Merging #103 (ddc05b0) into main (c37133e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #103   +/-   ##
=======================================
  Coverage   98.44%   98.44%           
=======================================
  Files         343      343           
  Lines       26640    26641    +1     
=======================================
+ Hits        26227    26228    +1     
  Misses        413      413           
Flag Coverage Δ
integration 98.44% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 98.44% <100.00%> (+<0.01%) ⬆️
unit 98.44% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 97.04% <100.00%> (+<0.01%) ⬆️
OutsideTasks 98.24% <100.00%> (+<0.01%) ⬆️
Files Changed Coverage Δ
database/models/reports.py 99.20% <100.00%> (+<0.01%) ⬆️
services/notification/__init__.py 97.39% <100.00%> (ø)

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #103 (ddc05b0) into main (c37133e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Changes have been made to critical files, which contain lines commonly executed in production. Learn more

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #103   +/-   ##
=======================================
  Coverage   98.48%   98.48%           
=======================================
  Files         364      364           
  Lines       26812    26813    +1     
=======================================
+ Hits        26406    26407    +1     
  Misses        406      406           
Flag Coverage Δ
integration 98.44% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 98.44% <100.00%> (+<0.01%) ⬆️
onlysomelabels 98.48% <100.00%> (+<0.01%) ⬆️
unit 98.44% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 97.14% <100.00%> (+<0.01%) ⬆️
OutsideTasks 98.24% <100.00%> (+<0.01%) ⬆️
Files Changed Coverage Δ
database/models/reports.py 99.20% <100.00%> (+<0.01%) ⬆️
services/notification/__init__.py Critical 97.41% <100.00%> (ø)
Related Entrypoints
run/app.tasks.notify.Notify

@joseph-sentry joseph-sentry marked this pull request as ready for review September 20, 2023 15:23
@joseph-sentry joseph-sentry merged commit 0bfac3e into main Sep 20, 2023
31 checks passed
@joseph-sentry joseph-sentry deleted the joseph/deleted-flag-status branch September 20, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants