Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change patch only comment's format #102

Merged
merged 2 commits into from
Sep 21, 2023
Merged

Conversation

dana-yaish
Copy link
Contributor

@dana-yaish dana-yaish commented Sep 20, 2023

In this PR we're making changes to the patch-only PR comment based on the new designs

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-public-qa
Copy link

codecov-public-qa bot commented Sep 20, 2023

Codecov Report

Merging #102 (8190505) into main (0bfac3e) will decrease coverage by 0.02%.
The diff coverage is 88.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #102      +/-   ##
==========================================
- Coverage   98.44%   98.43%   -0.02%     
==========================================
  Files         343      343              
  Lines       26641    26675      +34     
==========================================
+ Hits        26228    26257      +29     
- Misses        413      418       +5     
Flag Coverage Δ
integration 98.43% <88.46%> (-0.02%) ⬇️
latest-uploader-overall 98.43% <88.46%> (-0.02%) ⬇️
unit 98.43% <88.46%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 97.00% <84.61%> (-0.05%) ⬇️
OutsideTasks 98.21% <88.46%> (-0.03%) ⬇️
Files Changed Coverage Δ
...s/notification/notifiers/tests/unit/test_checks.py 98.26% <ø> (ø)
.../notification/notifiers/mixins/message/sections.py 97.56% <84.00%> (-0.98%) ⬇️
...s/notification/notifiers/mixins/message/helpers.py 92.59% <85.71%> (-1.16%) ⬇️
.../notification/notifiers/tests/unit/test_comment.py 100.00% <100.00%> (ø)

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #102 (8190505) into main (0bfac3e) will decrease coverage by 0.02%.
The diff coverage is 88.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #102      +/-   ##
==========================================
- Coverage   98.48%   98.46%   -0.02%     
==========================================
  Files         364      364              
  Lines       26813    26847      +34     
==========================================
+ Hits        26407    26436      +29     
- Misses        406      411       +5     
Flag Coverage Δ
integration 98.43% <88.46%> (-0.02%) ⬇️
latest-uploader-overall 98.43% <88.46%> (-0.02%) ⬇️
onlysomelabels 98.46% <88.46%> (-0.02%) ⬇️
unit 98.43% <88.46%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 97.09% <84.61%> (-0.05%) ⬇️
OutsideTasks 98.21% <88.46%> (-0.03%) ⬇️
Files Changed Coverage Δ
...s/notification/notifiers/tests/unit/test_checks.py 98.26% <ø> (ø)
.../notification/notifiers/mixins/message/sections.py 97.56% <84.00%> (-0.98%) ⬇️
...s/notification/notifiers/mixins/message/helpers.py 92.59% <85.71%> (-1.16%) ⬇️
.../notification/notifiers/tests/unit/test_comment.py 100.00% <100.00%> (ø)
Related Entrypoints
run/app.tasks.notify.Notify

@codecov-staging
Copy link

codecov-staging bot commented Sep 20, 2023

Codecov Report

Merging #102 (8190505) into main (0bfac3e) will decrease coverage by 0.02%.
The diff coverage is 88.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #102      +/-   ##
==========================================
- Coverage   98.44%   98.43%   -0.02%     
==========================================
  Files         343      343              
  Lines       26641    26675      +34     
==========================================
+ Hits        26228    26257      +29     
- Misses        413      418       +5     
Flag Coverage Δ
integration 98.43% <88.46%> (?)
latest-uploader-overall 98.43% <88.46%> (-0.02%) ⬇️
unit 98.43% <88.46%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 97.00% <84.61%> (-0.05%) ⬇️
OutsideTasks 98.21% <88.46%> (∅)
Files Changed Coverage
...s/notification/notifiers/tests/unit/test_checks.py ø
.../notification/notifiers/mixins/message/sections.py 84.00%
...s/notification/notifiers/mixins/message/helpers.py 85.71%
.../notification/notifiers/tests/unit/test_comment.py 100.00%

@dana-yaish dana-yaish merged commit 5aff524 into main Sep 21, 2023
20 of 31 checks passed
@dana-yaish dana-yaish deleted the dana/patch-only-changes branch September 21, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants