feat: Activate user who fired trial on trial expiration #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #101 +/- ##
=======================================
Coverage 98.47% 98.47%
=======================================
Files 364 364
Lines 26837 26850 +13
=======================================
+ Hits 26427 26440 +13
Misses 410 410
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov Report
@@ Coverage Diff @@
## main #101 +/- ##
=======================================
Coverage 98.43% 98.43%
=======================================
Files 343 343
Lines 26665 26678 +13
=======================================
+ Hits 26248 26261 +13
Misses 417 417
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov Report
@@ Coverage Diff @@
## main #101 +/- ##
=======================================
Coverage 98.43% 98.43%
=======================================
Files 343 343
Lines 26665 26678 +13
=======================================
+ Hits 26248 26261 +13
Misses 417 417
Flags with carried forward coverage won't be shown. Click here to find out more.
|
dana-yaish
reviewed
Sep 25, 2023
| @@ -73,6 +73,7 @@ class Owner(CodecovBaseModel): | |||
| trial_start_date = Column(types.DateTime, server_default=FetchedValue()) | |||
| trial_end_date = Column(types.DateTime, server_default=FetchedValue()) | |||
| trial_status = Column(types.Text, server_default=FetchedValue()) | |||
| trial_fired_by = Column(types.Integer, server_default=FetchedValue()) | |||
There was a problem hiding this comment.
is this column already in the database?
There was a problem hiding this comment.
I guess this value is set from the API side when the trial is activated?
dana-yaish
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On free plans, we offer 1 seat and we'd want to keep user who fired the trial activated post the trial.
codecov/engineering-team#406
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.