Skip to content

Commit

Permalink
fix: detected flake log (#714)
Browse files Browse the repository at this point in the history
  • Loading branch information
joseph-sentry committed Sep 17, 2024
1 parent e3cb698 commit b2c5405
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion tasks/test_results_finisher.py
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,7 @@ def process_impl_within_lock(
case _:
success = False

if flaky_tests is not None:
if len(flaky_tests):
log.info(
"Detected failure on test that has been identified as flaky",
extra=dict(
Expand All @@ -362,6 +362,7 @@ def process_impl_within_lock(
test_ids=list(flaky_tests.keys()),
),
)
metrics.incr("test_results.finisher.detected_flaky_test")

self.extra_dict["success"] = success
log.info(
Expand Down

0 comments on commit b2c5405

Please sign in to comment.