-
Notifications
You must be signed in to change notification settings - Fork 11
Turn labelanalysis and staticanalysis views into noops
#60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
99f29d0 to
eb2122e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #60 +/- ##
==========================================
- Coverage 94.25% 94.24% -0.02%
==========================================
Files 1211 1209 -2
Lines 45690 45539 -151
Branches 1449 1449
==========================================
- Hits 43067 42916 -151
Misses 2317 2317
Partials 306 306
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
eb2122e to
b51d3ef
Compare
joseph-sentry
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just leaving a note here for anyone that comes back to look at this code in the future that the reason we have to create staticanalyses/<uuid:external_id>/finish is because the action decorator that previously existed on the finish method off StaticAnalysisSuiteViewSet was implicitly creating that route
As part of deprecating ATS, this turns all the views into noops that return empty objects. Checking in with the requests that the CLI sends, returning an empty `external_id` and `absent_labels` for the labelanalysis will result in the CLI falling back to using the clientside requested labels. Similarly, returning an empty list of `filepaths` means that the CLI will not do any further uploads.
b51d3ef to
cb021bf
Compare
🚨 Sentry detected 3 potential issues in your recent changes 🚨Lower risk findings
Did you find this useful? React with a 👍 or 👎 |
(migrated from codecov/codecov-api#1233)
As part of deprecating ATS, this turns all the views into noops that return empty objects.
Checking in with the requests that the CLI sends, returning an empty
external_idandabsent_labelsfor the labelanalysis will result in the CLI falling back to using the clientside requested labels.Similarly, returning an empty list of
filepathsmeans that the CLI will not do any further uploads.