Skip to content

Conversation

@Swatinem
Copy link
Contributor

(migrated from codecov/codecov-api#1233)

As part of deprecating ATS, this turns all the views into noops that return empty objects.

Checking in with the requests that the CLI sends, returning an empty external_id and absent_labels for the labelanalysis will result in the CLI falling back to using the clientside requested labels.

Similarly, returning an empty list of filepaths means that the CLI will not do any further uploads.

@Swatinem Swatinem requested a review from a team April 28, 2025 07:24
@Swatinem Swatinem self-assigned this Apr 28, 2025
@Swatinem Swatinem force-pushed the codecov-api/swatinem/noop-analysis branch 2 times, most recently from 99f29d0 to eb2122e Compare April 28, 2025 09:40
@codecov
Copy link

codecov bot commented Apr 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.24%. Comparing base (b618863) to head (cb021bf).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #60      +/-   ##
==========================================
- Coverage   94.25%   94.24%   -0.02%     
==========================================
  Files        1211     1209       -2     
  Lines       45690    45539     -151     
  Branches     1449     1449              
==========================================
- Hits        43067    42916     -151     
  Misses       2317     2317              
  Partials      306      306              
Flag Coverage Δ
apiunit 96.38% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link

codecov-notifications bot commented Apr 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@Swatinem Swatinem force-pushed the codecov-api/swatinem/noop-analysis branch from eb2122e to b51d3ef Compare April 28, 2025 09:53
Copy link
Contributor

@joseph-sentry joseph-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just leaving a note here for anyone that comes back to look at this code in the future that the reason we have to create staticanalyses/<uuid:external_id>/finish is because the action decorator that previously existed on the finish method off StaticAnalysisSuiteViewSet was implicitly creating that route

@Swatinem Swatinem enabled auto-merge May 2, 2025 11:32
@Swatinem Swatinem disabled auto-merge May 2, 2025 11:33
As part of deprecating ATS, this turns all the views into noops that return empty objects.

Checking in with the requests that the CLI sends, returning an empty `external_id` and `absent_labels` for the labelanalysis will result in the CLI falling back to using the clientside requested labels.

Similarly, returning an empty list of `filepaths` means that the CLI will not do any further uploads.
@Swatinem Swatinem force-pushed the codecov-api/swatinem/noop-analysis branch from b51d3ef to cb021bf Compare May 2, 2025 11:36
@Swatinem Swatinem enabled auto-merge May 2, 2025 11:36
@seer-by-sentry
Copy link
Contributor

seer-by-sentry bot commented May 2, 2025

🚨 Sentry detected 3 potential issues in your recent changes 🚨

Lower risk findings

Did you find this useful? React with a 👍 or 👎

@Swatinem Swatinem added this pull request to the merge queue May 2, 2025
Merged via the queue into main with commit 1b59fc3 May 2, 2025
60 of 62 checks passed
@Swatinem Swatinem deleted the codecov-api/swatinem/noop-analysis branch May 2, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants