feat: add get_pipeline endpoint #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
related to codecov/engineering-team#2076 Apparently there are situations in which we want to post the commit checks to more than one commit, for GitLab (when merge result pipelines are enabled). In order to do this we have basicaly 2 options: 1. Get the extra commit SHAs, or 2. Save the extra commit SHAs. I don't think this is such a common situation for us, so that the cost of some extra requests to GitLab are less than the cost of making changes to the database to save the extra info (CLI sends extra SHA and it's saved in the Upload). So these changes introduce the endpoint that let's us get the pipeline details to see if we need to send commit statuses to multiple SHAs. The project ID is `Repository.service_id` and the job ID is `ReportSession.job_code`.
giovanni-guidini
added a commit
to codecov/worker
that referenced
this pull request
Sep 10, 2024
depends on codecov/shared#354 These changes collect extra SHAs that we need to (potentially) notify for GitLab users that use "merge request result" pipelines and the "merge train" feature. These changes only _collect_ the extra SHAs. The actual notification will happen later.
Swatinem
approved these changes
Sep 11, 2024
giovanni-guidini
added a commit
to codecov/worker
that referenced
this pull request
Sep 16, 2024
depends on codecov/shared#354 These changes collect extra SHAs that we need to (potentially) notify for GitLab users that use "merge request result" pipelines and the "merge train" feature. These changes only _collect_ the extra SHAs. The actual notification will happen later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to codecov/engineering-team#2076
Apparently there are situations in which we want to post the commit checks to more than one commit, for GitLab (when merge result pipelines are enabled).
In order to do this we have basicaly 2 options:
I don't think this is such a common situation for us, so that the cost of some extra
requests to GitLab are less than the cost of making changes to the database to save the
extra info (CLI sends extra SHA and it's saved in the Upload).
So these changes introduce the endpoint that let's us get the pipeline details to see
if we need to send commit statuses to multiple SHAs.
The project ID is
Repository.service_idand the job ID isReportSession.job_code.