BA: Handle multiple file versions + introduce gzip size #266
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a mechanism to handle parsing of different stats file versions, depending on the version value in the JSON file it will choose the appropriate parser logic. The difference between V1 and V2 is that V2 introduces gzip sizes for assets in the JSON file. In V2 parser it will read and store that value, whereas in V1 parser it will just use the old not-smart logic by assuming the gzip size is 1/1000th of the uncompressed size; beyond that V1 and V2 is identical in logic. The gzip size is then stored into the bundle report (ie SQLite DB).
I duplicated the code instead of modularizing it because having a bunch of version specific logic littered within one parser seems more unwieldy over time when there is many versions. Also with the proposed setup it helps with deprecating old ones where we can simply just delete old parsers and older versions' parsers shouldn't be touched most of the time.
closes codecov/engineering-team#1926
closes codecov/engineering-team#1927
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.