dev: Remove all the excluded ruff rules except E501 #235
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #235 +/- ##
==========================================
- Coverage 89.63% 89.54% -0.10%
==========================================
Files 328 324 -4
Lines 10482 10306 -176
Branches 1913 1878 -35
==========================================
- Hits 9396 9228 -168
+ Misses 1023 1008 -15
- Partials 63 70 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -26,6 +26,7 @@ exclude = [ | |||
| "node_modules", | |||
| "site-packages", | |||
| "venv", | |||
| "**test**" | |||
There was a problem hiding this comment.
One thing too, since there were many, many errors in the test files was I just excluded all of them for the sake of time. If someone wants to go back and fix those as well by all means :)
| @@ -16,3 +16,21 @@ | |||
| ModuleReport, | |||
| ) | |||
| from shared.bundle_analysis.storage import BundleAnalysisReportLoader, StoragePaths | |||
|
|
|||
| __all__ = [ | |||
| "models", | |||
There was a problem hiding this comment.
This is how we can get around the "unused imports" for these init files
| @@ -219,8 +219,8 @@ def diff_to_json(self, diff): | |||
| elif sol4 == "@@ -": | |||
| # ex: "@@ -31,8 +31,8 @@ blah blah blah" | |||
| # ex: "@@ -0,0 +1 @@" | |||
| l = get_start_of_line(source).groups() | |||
There was a problem hiding this comment.
"l" is an ambiguous character, and rightfully so. changed to "ln" to signal "line" which is what "l" was originally representing
| @@ -802,7 +802,7 @@ async def find_pull_request( | |||
| self, commit=None, branch=None, state="open", token=None | |||
| ): | |||
| state = {"open": "OPEN", "merged": "MERGED", "close": "DECLINED"}.get(state, "") | |||
| pulls, page = [], 0 | |||
There was a problem hiding this comment.
pulls wasn't being populated here, just an empty array
Part of the lint enhancement epic: codecov/engineering-team#1716
This PR aims to fix all the "hanging" F and E rules that we excluded previously. The rules that we are now enforcing are as follows:
Rules List: https://docs.astral.sh/ruff/rules/#legend
This leaves one remaining rule, E501, which is about line length unchanged. I think for now it doesn't make sense to add this as an enforced rule since it's more stylistic, but we can always consider turning it on later.
Closes codecov/engineering-team#1852
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.