dev: Add most "F" Rules on shared #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajay-sentry
commented
May 28, 2024
| @@ -45,3 +45,6 @@ test_env.up: | |||
|
|
|||
| test_env.test: | |||
| docker-compose exec shared python -m pytest --cov=./ --junitxml=junit.xml | |||
|
|
|||
| test_env.down: | |||
There was a problem hiding this comment.
Also added a make test_env down command since I didn't see one in the file :)
ajay-sentry
commented
May 28, 2024
| @@ -943,7 +943,7 @@ def get_file_totals(self, path, _else=None): | |||
| """ | |||
| returns <ReportTotals> for the file if it exists | |||
| """ | |||
| if self._path_filter and not self._path_filter(filename): | |||
| if self._path_filter and not self._path_filter(path): | |||
There was a problem hiding this comment.
@matt-codecov This one
ajay-sentry
commented
May 28, 2024
| @@ -104,7 +104,7 @@ def test_decrypt_token_key_normal_generated_with_secret_pair(): | |||
| assert res == {"key": value.split(":")[0], "secret": value.split(":")[1]} | |||
|
|
|||
|
|
|||
| def test_decrypt_token_key_normal_generated_with_secret_pair(): | |||
| def test_decrypt_token_key_normal_generated_with_secret_pair_1(): | |||
There was a problem hiding this comment.
duplicate test names for this and below
ajay-sentry
commented
May 28, 2024
| @@ -23,7 +23,6 @@ | |||
| { | |||
| "f": 203, | |||
| "h": 2549, | |||
| "m": 0, | |||
There was a problem hiding this comment.
duplicate keys for this and below
rohitvinnakota-codecov
previously approved these changes
May 29, 2024
rohitvinnakota-codecov
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add a majority of the F rules to our ruff setup on "shared", including fixing a number of errors stemming from turning those errors on.
Part of the lint enhancement epic here: codecov/engineering-team#1716
Ruff F rules are the Pyflakes rules: https://docs.astral.sh/ruff/rules/#pyflakes-f
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.