-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lazy load bundle analysis bucket name #102
Conversation
Codecov Report
@@ Coverage Diff @@
## main #102 +/- ##
=======================================
Coverage 89.41% 89.42%
=======================================
Files 115 115
Lines 9383 9386 +3
Branches 1486 1486
=======================================
+ Hits 8390 8393 +3
Misses 789 789
Partials 204 204
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #102 +/- ##
=======================================
Coverage 89.41% 89.42%
=======================================
Files 115 115
Lines 9383 9386 +3
Branches 1486 1486
=======================================
+ Hits 8390 8393 +3
Misses 789 789
Partials 204 204
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #102 +/- ##
=======================================
Coverage 91.43% 91.44%
=======================================
Files 122 122
Lines 9404 9407 +3
Branches 1600 1600
=======================================
+ Hits 8599 8602 +3
Misses 789 789
Partials 16 16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Was seeing the default being used in staging even though we have a config var set for this. Not sure if there's some kind of race condition at module initialization time.
Also added the upload storage path (which is currently specified in the API).