Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy load bundle analysis bucket name #102

Merged
merged 2 commits into from
Dec 19, 2023

Conversation

scott-codecov
Copy link
Contributor

Was seeing the default being used in staging even though we have a config var set for this. Not sure if there's some kind of race condition at module initialization time.

Also added the upload storage path (which is currently specified in the API).

Copy link

codecov-public-qa bot commented Dec 19, 2023

Codecov Report

Merging #102 (6a6fb49) into main (8196e5c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #102   +/-   ##
=======================================
  Coverage   89.41%   89.42%           
=======================================
  Files         115      115           
  Lines        9383     9386    +3     
  Branches     1486     1486           
=======================================
+ Hits         8390     8393    +3     
  Misses        789      789           
  Partials      204      204           
Flag Coverage Δ
python3.10 88.62% <100.00%> (+<0.01%) ⬆️
python3.11 88.62% <100.00%> (+<0.01%) ⬆️
python3.12 88.62% <100.00%> (+<0.01%) ⬆️
python3.8 88.70% <100.00%> (+<0.01%) ⬆️
python3.9 88.97% <100.00%> (+<0.01%) ⬆️
rust 90.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
shared/bundle_analysis/storage.py 100.00% <100.00%> (ø)

Impacted file tree graph

@codecov-qa
Copy link

codecov-qa bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8196e5c) 89.41% compared to head (6a6fb49) 89.42%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #102   +/-   ##
=======================================
  Coverage   89.41%   89.42%           
=======================================
  Files         115      115           
  Lines        9383     9386    +3     
  Branches     1486     1486           
=======================================
+ Hits         8390     8393    +3     
  Misses        789      789           
  Partials      204      204           
Flag Coverage Δ
python3.10 88.62% <100.00%> (+<0.01%) ⬆️
python3.11 88.62% <100.00%> (+<0.01%) ⬆️
python3.12 88.62% <100.00%> (+<0.01%) ⬆️
python3.8 88.70% <100.00%> (+<0.01%) ⬆️
python3.9 88.97% <100.00%> (+<0.01%) ⬆️
rust 90.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-staging
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@scott-codecov scott-codecov changed the title Scott/bundle analysis bucket name Lazy load bundle analysis bucket name Dec 19, 2023
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8196e5c) 91.43% compared to head (6a6fb49) 91.44%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #102   +/-   ##
=======================================
  Coverage   91.43%   91.44%           
=======================================
  Files         122      122           
  Lines        9404     9407    +3     
  Branches     1600     1600           
=======================================
+ Hits         8599     8602    +3     
  Misses        789      789           
  Partials       16       16           
Flag Coverage Δ
python3.10 88.62% <100.00%> (+<0.01%) ⬆️
python3.11 88.62% <100.00%> (+<0.01%) ⬆️
python3.12 88.62% <100.00%> (+<0.01%) ⬆️
python3.8 88.70% <100.00%> (+<0.01%) ⬆️
python3.9 88.97% <100.00%> (+<0.01%) ⬆️
rust 90.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scott-codecov scott-codecov merged commit a8f69f9 into main Dec 19, 2023
24 of 25 checks passed
@scott-codecov scott-codecov deleted the scott/bundle-analysis-bucket-name branch December 19, 2023 17:15
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants