Skip to content

ref: Update delete account messaging #2892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nicholas-codecov merged 8 commits into from
Jun 3, 2024
Merged

ref: Update delete account messaging #2892

nicholas-codecov merged 8 commits into from
Jun 3, 2024

Conversation

@nicholas-codecov
Copy link
Contributor

@nicholas-codecov nicholas-codecov commented May 23, 2024

Description

Quick PR changing the messaging around personal account deletion.

Notable Changes

  • Remove account removal button
  • Update messaging to contact support for help with account deletion
  • Move to TS
  • Update tests

Screenshots

Screenshot 2024-05-23 at 08 35 18

@codecov-qa
Copy link

codecov-qa bot commented May 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.45%. Comparing base (2d764f5) to head (15c7708).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2892      +/-   ##
==========================================
- Coverage   98.46%   98.45%   -0.01%     
==========================================
  Files         886      884       -2     
  Lines       13124    13096      -28     
  Branches     3511     3441      -70     
==========================================
- Hits        12922    12894      -28     
  Misses        198      198              
  Partials        4        4
Files Coverage Δ
...tSettings/tabs/Admin/DeletionCard/DeletionCard.tsx 100.00% <100.00%> (ø)
...ettings/tabs/Profile/DeletionCard/DeletionCard.tsx 100.00% <100.00%> (ø)
src/pages/AccountSettings/tabs/Profile/Profile.jsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.22% <ø> (ø)
Pages 99.27% <100.00%> (-0.01%) ⬇️
Services 99.48% <ø> (ø)
Shared 99.68% <ø> (ø)
UI 94.73% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d764f5...15c7708. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented May 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2892      +/-   ##
==========================================
- Coverage   98.46%   98.45%   -0.01%     
==========================================
  Files         886      884       -2     
  Lines       13124    13096      -28     
  Branches     3506     3441      -65     
==========================================
- Hits        12922    12894      -28     
  Misses        198      198              
  Partials        4        4
Files Coverage Δ
...tSettings/tabs/Admin/DeletionCard/DeletionCard.tsx 100.00% <100.00%> (ø)
...ettings/tabs/Profile/DeletionCard/DeletionCard.tsx 100.00% <100.00%> (ø)
src/pages/AccountSettings/tabs/Profile/Profile.jsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.22% <ø> (ø)
Pages 99.27% <100.00%> (-0.01%) ⬇️
Services 99.48% <ø> (ø)
Shared 99.68% <ø> (ø)
UI 94.73% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d764f5...15c7708. Read the comment docs.

@codecov-public-qa
Copy link

codecov-public-qa bot commented May 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.45%. Comparing base (2d764f5) to head (15c7708).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2892      +/-   ##
==========================================
- Coverage   98.46%   98.45%   -0.01%     
==========================================
  Files         886      884       -2     
  Lines       13124    13096      -28     
  Branches     3506     3511       +5     
==========================================
- Hits        12922    12894      -28     
  Misses        198      198              
  Partials        4        4
Files Coverage Δ
...tSettings/tabs/Admin/DeletionCard/DeletionCard.tsx 100.00% <100.00%> (ø)
...ettings/tabs/Profile/DeletionCard/DeletionCard.tsx 100.00% <100.00%> (ø)
src/pages/AccountSettings/tabs/Profile/Profile.jsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.22% <ø> (ø)
Pages 99.27% <100.00%> (-0.01%) ⬇️
Services 99.48% <ø> (ø)
Shared 99.68% <ø> (ø)
UI 94.73% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d764f5...15c7708. Read the comment docs.

@codecov
Copy link

codecov bot commented May 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.45%. Comparing base (2d764f5) to head (15c7708).

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##               main      #2892        +/-   ##
================================================
- Coverage   98.46000   98.45000   -0.01000     
================================================
  Files           886        884         -2     
  Lines         13124      13096        -28     
  Branches       3511       3487        -24     
================================================
- Hits          12922      12894        -28     
  Misses          198        198                
  Partials          4          4
Files Coverage Δ
...tSettings/tabs/Admin/DeletionCard/DeletionCard.tsx 100.00% <100.00%> (ø)
...ettings/tabs/Profile/DeletionCard/DeletionCard.tsx 100.00% <100.00%> (ø)
src/pages/AccountSettings/tabs/Profile/Profile.jsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.22% <ø> (ø)
Pages 99.27% <100.00%> (-0.01%) ⬇️
Services 99.48% <ø> (ø)
Shared 99.68% <ø> (ø)
UI 94.73% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d764f5...15c7708. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented May 23, 2024 •
edited
Loading

Bundle Report

Changes will decrease total bundle size by 13.13kB ⬇️

Bundle name Size Change
gazebo-staging-array-push 6.93MB 13.13kB ⬇️

@codecov
Copy link

codecov bot commented May 23, 2024 •
edited
Loading

Bundle Report

Changes will decrease total bundle size by 13.13kB ⬇️

Bundle name Size Change
gazebo-production-array-push 6.93MB 13.13kB ⬇️

@codecov-releaser
Copy link
Collaborator

codecov-releaser commented May 23, 2024 •
edited
Loading

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
cd3024c Thu, 23 May 2024 11:55:20 GMT Expired Expired
c16c0f6 Tue, 28 May 2024 17:13:34 GMT Expired Expired
aa75d9b Tue, 28 May 2024 17:33:49 GMT Expired Expired
15c7708 Mon, 03 Jun 2024 10:55:54 GMT Cloud Enterprise

rohitvinnakota-codecov
rohitvinnakota-codecov reviewed May 24, 2024
View reviewed changes
src/pages/AccountSettings/tabs/Admin/DeletionCard/DeletionCard.tsx
isPersonalSettings: boolean
}

function EraseSection({ isPersonalSettings }: EraseSectionProps) {
Copy link
Contributor

@rohitvinnakota-codecov rohitvinnakota-codecov May 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the difference between this and the other DeletionCard component in the profile tab? Do we want to update that too?

Copy link
Contributor Author

@nicholas-codecov nicholas-codecov May 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hrmrmrm profile tab is self hosted only or DEC, let me go ask in the ticket.

Copy link
Contributor Author

@nicholas-codecov nicholas-codecov Jun 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They wanted it on both

@nicholas-codecov nicholas-codecov added this pull request to the merge queue Jun 3, 2024
Merged via the queue into main with commit dd56fc4 Jun 3, 2024
@nicholas-codecov nicholas-codecov deleted the gh-int-388-update-delete-account-messaging branch June 3, 2024 14:17
This was referenced Feb 14, 2025
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rohitvinnakota-codecov rohitvinnakota-codecov rohitvinnakota-codecov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nicholas-codecov @codecov-releaser @rohitvinnakota-codecov @nsdeschenes