Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Convert file entry stuff to ts #2698

Merged
merged 5 commits into from
Mar 28, 2024

Conversation

spalmurray-codecov
Copy link
Contributor

Copy link

codecov-public-qa bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c59b171) 98.43% compared to head (5d0839c) 98.43%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2698   +/-   ##
=======================================
  Coverage   98.43%   98.43%           
=======================================
  Files         855      855           
  Lines       12092    12112   +20     
  Branches     3129     3188   +59     
=======================================
+ Hits        11903    11923   +20     
  Misses        185      185           
  Partials        4        4           
Files Coverage Δ
src/services/file/useCoverageWithFilters.js 100.00% <100.00%> (ø)
src/services/file/utils.ts 100.00% <100.00%> (ø)
...Contents/branch/file/usePrefetchBranchFileEntry.js 100.00% <100.00%> (ø)
...ontents/commit/file/usePrefetchCommitFileEntry.tsx 100.00% <100.00%> (ø)
src/services/pathContents/constants.ts 100.00% <100.00%> (ø)
...athContents/pull/file/usePrefetchPullFileEntry.tsx 100.00% <100.00%> (ø)
...tsTable/TableEntries/PullEntries/PullFileEntry.tsx 100.00% <100.00%> (ø)
src/shared/ContentsTable/constants.ts 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.13% <ø> (ø)
Pages 99.31% <ø> (ø)
Services 99.58% <100.00%> (+<0.01%) ⬆️
Shared 99.83% <100.00%> (-0.01%) ⬇️
UI 94.17% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c59b171...5d0839c. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.43%. Comparing base (c59b171) to head (5d0839c).

✅ All tests successful. No failed tests found ☺️

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2698   +/-   ##
=======================================
  Coverage   98.43%   98.43%           
=======================================
  Files         855      855           
  Lines       12092    12112   +20     
  Branches     3129     3188   +59     
=======================================
+ Hits        11903    11923   +20     
  Misses        185      185           
  Partials        4        4           
Files Coverage Δ
src/services/file/useCoverageWithFilters.js 100.00% <100.00%> (ø)
src/services/file/utils.ts 100.00% <100.00%> (ø)
...Contents/branch/file/usePrefetchBranchFileEntry.js 100.00% <100.00%> (ø)
...ontents/commit/file/usePrefetchCommitFileEntry.tsx 100.00% <100.00%> (ø)
src/services/pathContents/constants.ts 100.00% <100.00%> (ø)
...athContents/pull/file/usePrefetchPullFileEntry.tsx 100.00% <100.00%> (ø)
...tsTable/TableEntries/PullEntries/PullFileEntry.tsx 100.00% <100.00%> (ø)
src/shared/ContentsTable/constants.ts 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.13% <ø> (ø)
Pages 99.31% <ø> (ø)
Services 99.58% <100.00%> (+<0.01%) ⬆️
Shared 99.83% <100.00%> (-0.01%) ⬇️
UI 94.17% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c59b171...5d0839c. Read the comment docs.

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.44%. Comparing base (c59b171) to head (5d0839c).

✅ All tests successful. No failed tests found ☺️

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2698   +/-   ##
=====================================
  Coverage   98.44   98.44           
=====================================
  Files        855     855           
  Lines      12092   12112   +20     
  Branches    3129    3188   +59     
=====================================
+ Hits       11903   11923   +20     
  Misses       185     185           
  Partials       4       4           
Files Coverage Δ
src/services/file/useCoverageWithFilters.js 100.00% <100.00%> (ø)
src/services/file/utils.ts 100.00% <100.00%> (ø)
...Contents/branch/file/usePrefetchBranchFileEntry.js 100.00% <100.00%> (ø)
...ontents/commit/file/usePrefetchCommitFileEntry.tsx 100.00% <100.00%> (ø)
src/services/pathContents/constants.ts 100.00% <100.00%> (ø)
...athContents/pull/file/usePrefetchPullFileEntry.tsx 100.00% <100.00%> (ø)
...tsTable/TableEntries/PullEntries/PullFileEntry.tsx 100.00% <100.00%> (ø)
src/shared/ContentsTable/constants.ts 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.13% <ø> (ø)
Pages 99.31% <ø> (ø)
Services 99.58% <100.00%> (+<0.01%) ⬆️
Shared 99.83% <100.00%> (-0.01%) ⬇️
UI 94.17% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c59b171...5d0839c. Read the comment docs.

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Mar 13, 2024

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Commit Created Cloud Enterprise
7e92305 Wed, 13 Mar 2024 19:57:42 GMT Expired Expired
7e92305 Wed, 13 Mar 2024 19:58:25 GMT Expired Expired
caddfda Wed, 13 Mar 2024 20:13:54 GMT Expired Expired
caddfda Wed, 13 Mar 2024 20:23:07 GMT Expired Expired
c647ebf Wed, 13 Mar 2024 20:49:33 GMT Expired Expired
d1d632e Thu, 14 Mar 2024 13:35:50 GMT Expired Expired
76bdb39 Wed, 27 Mar 2024 13:34:09 GMT Expired Expired
5d0839c Thu, 28 Mar 2024 19:26:25 GMT Cloud Enterprise

@spalmurray-codecov spalmurray-codecov marked this pull request as ready for review March 13, 2024 20:04
@spalmurray-codecov spalmurray-codecov force-pushed the usePrefetchFileEntry-ts-refactor branch 2 times, most recently from c647ebf to d1d632e Compare March 14, 2024 13:18
Copy link
Contributor

@nicholas-codecov nicholas-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some things to take a peak at, looking good tho

@codecov-notifications
Copy link

codecov-notifications bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2698   +/-   ##
=======================================
  Coverage   98.43%   98.43%           
=======================================
  Files         855      855           
  Lines       12092    12112   +20     
  Branches     3185     3188    +3     
=======================================
+ Hits        11903    11923   +20     
  Misses        185      185           
  Partials        4        4           
Files Coverage Δ
src/services/file/useCoverageWithFilters.js 100.00% <100.00%> (ø)
src/services/file/utils.ts 100.00% <100.00%> (ø)
...Contents/branch/file/usePrefetchBranchFileEntry.js 100.00% <100.00%> (ø)
...ontents/commit/file/usePrefetchCommitFileEntry.tsx 100.00% <100.00%> (ø)
src/services/pathContents/constants.ts 100.00% <100.00%> (ø)
...athContents/pull/file/usePrefetchPullFileEntry.tsx 100.00% <100.00%> (ø)
...tsTable/TableEntries/PullEntries/PullFileEntry.tsx 100.00% <100.00%> (ø)
src/shared/ContentsTable/constants.ts 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.13% <ø> (ø)
Pages 99.31% <ø> (ø)
Services 99.58% <100.00%> (+<0.01%) ⬆️
Shared 99.83% <100.00%> (-0.01%) ⬇️
UI 94.17% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c59b171...5d0839c. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented Mar 27, 2024

Bundle Report

Changes will increase total bundle size by 997 bytes ⬆️

Bundle name Size Change
gazebo-staging-array-push 5.97MB 997 bytes ⬆️

Copy link

codecov bot commented Mar 27, 2024

Bundle Report

Changes will increase total bundle size by 997 bytes ⬆️

Bundle name Size Change
gazebo-production-array-push 5.97MB 997 bytes ⬆️

Copy link
Contributor

@nicholas-codecov nicholas-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@spalmurray-codecov spalmurray-codecov merged commit d2a63eb into main Mar 28, 2024
58 checks passed
@spalmurray-codecov spalmurray-codecov deleted the usePrefetchFileEntry-ts-refactor branch March 28, 2024 19:40
RulaKhaled added a commit that referenced this pull request Apr 3, 2024
* feat: Create useRepoComponents hook

* We need branch not term

* fix: Handle guest feature error, no nested catch (#2709)

* fix: Handle guest feature error, no nested catch

* Update tests to reflect graphql error

* Fix when to raise an error

* my bad bro

* Update to re add catch block

* build: grab github sha from env (#2672)

Update Sentry deps and bundler plugin config to prepare for incoming fix to source map uploading.

* ref: Convert file entry stuff to ts (#2698)

Part of codecov/engineering-team#588

* chore: Remove bundle analysis flags (#2693)

Remove bundle analysis feature flags from Gazebo.

GH codecov/engineering-team#999
GH codecov/engineering-team#1214

* Prepare release 24.4.1 (#2737)

* Update to use react props with children

---------

Co-authored-by: nicholas-codecov <[email protected]>
Co-authored-by: Spencer Murray <[email protected]>
Co-authored-by: Codecov Releaser <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants