Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create hook to fetch bundle analysis summary for a pull #2494

Conversation

nicholas-codecov
Copy link
Contributor

Description

This PR adds in a new hook that will be used to get the information required for the bundle analysis dropdown that will be used when both Coverage and a Bundle analysis data is present inside a repo for a given pull.

GH codecov/engineering-team#992

Notable Changes

  • Create new usePullBADropdownSummary hook
  • Write up tests for usePullBADropdownSummary

@codecov-staging
Copy link

codecov-staging bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2494   +/-   ##
=======================================
  Coverage   98.23%   98.23%           
=======================================
  Files         779      780    +1     
  Lines        9909     9927   +18     
  Branches     2524     2527    +3     
=======================================
+ Hits         9734     9752   +18     
  Misses        173      173           
  Partials        2        2           
Files Coverage Δ
src/services/commit/useCommitBADropdownSummary.tsx 100.00% <100.00%> (ø)
src/services/pull/usePullBADropdownSummary.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.23% <ø> (ø)
Services 99.46% <100.00%> (+<0.01%) ⬆️
Shared 99.82% <ø> (ø)
UI 94.17% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e550942...596f838. Read the comment docs.

Copy link

codecov-public-qa bot commented Jan 8, 2024

Codecov Report

Merging #2494 (596f838) into main (e550942) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2494   +/-   ##
=======================================
  Coverage   98.23%   98.23%           
=======================================
  Files         779      780    +1     
  Lines        9909     9927   +18     
  Branches     2524     2481   -43     
=======================================
+ Hits         9734     9752   +18     
  Misses        173      173           
  Partials        2        2           
Files Coverage Δ
src/services/commit/useCommitBADropdownSummary.tsx 100.00% <100.00%> (ø)
src/services/pull/usePullBADropdownSummary.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.23% <ø> (ø)
Services 99.46% <100.00%> (+<0.01%) ⬆️
Shared 99.82% <ø> (ø)
UI 94.17% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e550942...596f838. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e550942) 98.23% compared to head (596f838) 98.23%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2494   +/-   ##
=======================================
  Coverage   98.23%   98.23%           
=======================================
  Files         779      780    +1     
  Lines        9909     9927   +18     
  Branches     2478     2513   +35     
=======================================
+ Hits         9734     9752   +18     
  Misses        173      173           
  Partials        2        2           
Files Coverage Δ
src/services/commit/useCommitBADropdownSummary.tsx 100.00% <100.00%> (ø)
src/services/pull/usePullBADropdownSummary.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.23% <ø> (ø)
Services 99.46% <100.00%> (+<0.01%) ⬆️
Shared 99.82% <ø> (ø)
UI 94.17% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e550942...596f838. Read the comment docs.

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e550942) 98.23% compared to head (596f838) 98.24%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2494     +/-   ##
=======================================
+ Coverage   98.23   98.24   +0.01     
=======================================
  Files        779     780      +1     
  Lines       9909    9927     +18     
  Branches    2480    2532     +52     
=======================================
+ Hits        9734    9752     +18     
  Misses       173     173             
  Partials       2       2             
Files Coverage Δ
src/services/commit/useCommitBADropdownSummary.tsx 100.00% <100.00%> (ø)
src/services/pull/usePullBADropdownSummary.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.23% <ø> (ø)
Services 99.46% <100.00%> (+<0.01%) ⬆️
Shared 99.82% <ø> (ø)
UI 94.17% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e550942...596f838. Read the comment docs.

Copy link

netlify bot commented Jan 8, 2024

Deploy Preview for gazebo-staging ready!

Name Link
🔨 Latest commit 596f838
🔍 Latest deploy log https://app.netlify.com/sites/gazebo-staging/deploys/659d96b1c2c6b300085720d9
😎 Deploy Preview https://deploy-preview-2494--gazebo-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nicholas-codecov nicholas-codecov force-pushed the gh-eng-992-create-hook-to-fetch-bundle-analysis-summary-for-a-pull branch from 235517d to 6950de6 Compare January 9, 2024 18:46
@nicholas-codecov nicholas-codecov merged commit 1c76f66 into main Jan 9, 2024
56 of 58 checks passed
@nicholas-codecov nicholas-codecov deleted the gh-eng-992-create-hook-to-fetch-bundle-analysis-summary-for-a-pull branch January 9, 2024 19:06
RulaKhaled pushed a commit that referenced this pull request Jan 11, 2024
Create a new hook that fetches bundle analysis information for a given pull, and a few fixes to a previously merged hook.

GH codecov/engineering-team#992
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants